[miio] adding new devices #7273

marcelrv · 2020-04-02T20:03:09Z

Adding several new devices. including:
yeelink.light.color4 #7016
Mi Home PTX Wall Switches (090615.switch.xswitch03) #7000
Xiaomi Ceiling Lamp (yeelink.light.ceiling11) #6787
Additional sensors and information in zhimi.airpurifier.v7 #5760

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

TravisBuddy · 2020-04-02T20:06:13Z

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister · 2020-04-02T21:06:16Z

bundles/org.openhab.binding.miio/src/main/resources/database/yeelink.light.color1.json

@@ -4,6 +4,7 @@
 "yeelink.light.color1",
 "yeelink.light.color2",
 "yeelink.light.color3",
+ "yeelink.light.color4",


use tabs to make this consistent with everything else.

cpmeister · 2020-04-02T21:07:49Z

bundles/org.openhab.binding.miio/README.md

@@ -307,7 +315,7 @@ e.g. `smarthome:send actionCommand 'upd_timer["1498595904821", "on"]'` would ena
 | Channel | Type | Description |
 |------------------|---------|-------------------------------------|
 | power | Switch | Power |
-| mode  | String | Mode |
+| humidifierMode | String | Mode |


Maybe update the description too? The channel name has more information than the description does...

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

marcelrv · 2020-04-03T17:55:38Z

note, I moved the 2 typo's correction in the readme to the cloud PR o avoid merge conflict.

TravisBuddy · 2020-04-03T17:57:39Z

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister

There are probably a lot more "Shutdowm" misspells that were out of scope of this PR. Not sure if you should fix them all as part of this PR though 😕

cpmeister · 2020-04-03T17:57:11Z

bundles/org.openhab.binding.miio/README.base.md

-However, many devices share large similarities with existing devices.
+However, many devices share large similarties with existing devices.


The original spelling was correct

Yes, I known.. to avoid the usual git voodoo I made the comment earlier: note, I moved the 2 typo's correction in the readme to the cloud PR to avoid merge conflict.

Ah, you didn't specify which two you moved though, lol.

cpmeister · 2020-04-03T17:57:24Z

bundles/org.openhab.binding.miio/README.md

-However, many devices share large similarities with existing devices.
+However, many devices share large similarties with existing devices.


cpmeister · 2020-04-03T17:59:05Z

bundles/org.openhab.binding.miio/README.md

+Group G_light "Yeelight LED Ceiling Lamp v9" <status>
+Switch power "Power" (G_light) {channel="miio:basic:light:power"}
+Number brightness "Brightness" (G_light) {channel="miio:basic:light:brightness"}
+Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}


Suggested change

Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}

Number delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

cpmeister · 2020-04-03T17:59:24Z

bundles/org.openhab.binding.miio/README.md

+Group G_light "Yeelight LED Ceiling Lamp v11" <status>
+Switch power "Power" (G_light) {channel="miio:basic:light:power"}
+Number brightness "Brightness" (G_light) {channel="miio:basic:light:brightness"}
+Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}


Suggested change

Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}

Number delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

cpmeister · 2020-04-03T17:59:35Z

bundles/org.openhab.binding.miio/README.md

+Group G_light "Yeelight LED Ceiling Lamp v12" <status>
+Switch power "Power" (G_light) {channel="miio:basic:light:power"}
+Number brightness "Brightness" (G_light) {channel="miio:basic:light:brightness"}
+Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}


Suggested change

Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}

Number delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

cpmeister · 2020-04-03T17:59:50Z

bundles/org.openhab.binding.miio/README.md

+Group G_light "Yeelight LED Ceiling Lamp v13" <status>
+Switch power "Power" (G_light) {channel="miio:basic:light:power"}
+Number brightness "Brightness" (G_light) {channel="miio:basic:light:brightness"}
+Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}


Suggested change

Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}

Number delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

cpmeister · 2020-04-03T18:00:39Z

bundles/org.openhab.binding.miio/README.md

+Group G_light "Yeelight Color Bulb YLDP02YL 9W" <status>
+Switch power "Power" (G_light) {channel="miio:basic:light:power"}
+Number brightness "Brightness" (G_light) {channel="miio:basic:light:brightness"}
+String delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}


Suggested change

String delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}

String delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

cpmeister · 2020-04-03T18:02:27Z

bundles/org.openhab.binding.miio/src/main/resources/database/yeelink.light.ceiling.json

+ },
+ {
+ "property": "delayoff",
+ "friendlyName": "Shutdowm Timer",


Suggested change

"friendlyName": "Shutdowm Timer",

"friendlyName": "Shutdown Timer",

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

marcelrv · 2020-04-03T18:35:30Z

Yes, seems the Shutdowm typo was there since early on and copied to the many derivatives.

TravisBuddy · 2020-04-03T18:35:40Z

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister

LGTM

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Eugen Freiter <freiter@gmx.de>

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: CSchlipp <christian@schlipp.de>

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>

Adding several new devices. including: yeelink.light.color4 openhab#7016 Mi Home PTX Wall Switches (090615.switch.xswitch03) openhab#7000 Xiaomi Ceiling Lamp (yeelink.light.ceiling11) openhab#6787 Additional sensors and information in zhimi.airpurifier.v7 openhab#5760 fix formatting and channel correct Shutdowm typo Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

cpmeister requested changes Apr 2, 2020

View reviewed changes

cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 3, 2020

This was linked to issues Apr 3, 2020

[miio] Add support for Mi Home PTX Wall Switches (090615.switch.xswitch03) #7000

Closed

[miio] Add support for Xiaomi Ceiling Lamp (yeelink.light.ceiling11) #6787

Closed

cpmeister removed a link to an issue Apr 3, 2020

[miio] Add support for Mi Home PTX Wall Switches (090615.switch.xswitch03) #7000

Closed

This was linked to issues Apr 3, 2020

[miio] Add support for Mi Home PTX Wall Switches (090615.switch.xswitch03) #7000

Closed

[miio] feature request support for yeelink.light.color4 #7016

Closed

[miio] Additional sensors and information in zhimi.airpurifier.v7 #5760

Closed

[miio] fix formatting and channel

cf1ef5e

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

marcelrv requested a review from cpmeister April 3, 2020 17:55

cpmeister requested changes Apr 3, 2020

View reviewed changes

[miio] correct Shutdowm typo

1dc7a48

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

cpmeister approved these changes Apr 3, 2020

View reviewed changes

cpmeister merged commit d8c7e00 into openhab:2.5.x Apr 3, 2020

cpmeister added this to the 2.5.4 milestone Apr 3, 2020

marcelrv deleted the miio-april20 branch April 3, 2020 20:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[miio] adding new devices #7273

[miio] adding new devices #7273

marcelrv commented Apr 2, 2020

TravisBuddy commented Apr 2, 2020

cpmeister Apr 2, 2020

cpmeister Apr 2, 2020

marcelrv commented Apr 3, 2020

TravisBuddy commented Apr 3, 2020

cpmeister left a comment

cpmeister Apr 3, 2020

marcelrv Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

cpmeister Apr 3, 2020

marcelrv commented Apr 3, 2020

TravisBuddy commented Apr 3, 2020

cpmeister left a comment

		However, many devices share large similarities with existing devices.
		However, many devices share large similarties with existing devices.

	Number delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}
	Number delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

	String delayoff "Shutdowm Timer" (G_light) {channel="miio:basic:light:delayoff"}
	String delayoff "Shutdown Timer" (G_light) {channel="miio:basic:light:delayoff"}

	"friendlyName": "Shutdowm Timer",
	"friendlyName": "Shutdown Timer",

[miio] adding new devices #7273

[miio] adding new devices #7273

Conversation

marcelrv commented Apr 2, 2020

TravisBuddy commented Apr 2, 2020

Travis tests were successful

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcelrv commented Apr 3, 2020

TravisBuddy commented Apr 3, 2020

Travis tests were successful

cpmeister left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcelrv commented Apr 3, 2020

TravisBuddy commented Apr 3, 2020

Travis tests were successful

cpmeister left a comment

Choose a reason for hiding this comment