Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enera][WIP] Enera binding initial contribution #7313

Closed
wants to merge 5 commits into from
Closed

[enera][WIP] Enera binding initial contribution #7313

wants to merge 5 commits into from

Conversation

oliverrahner
Copy link

Hi,

as this is my first binding, I am sure I missed some things, even though I tried to respect all available documentation and guidelines.

What I know is still missing:

  • lots of Warnings regarding @nullable handling
  • Unit Tests
  • i18n

I am very open for any kind of feedback!

@TravisBuddy
Copy link

Travis tests have failed

Hey @oliverrahner,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@oliverrahner
[enera] Enera binding initial contribution (openhab#7312)
22745ff 
Signed-off-by: Oliver Rahner <oliver@rahner.me>
@oliverrahner
Copy link
Author

Sorry, this got closed as I needed to fix some git mistakes I made...

@oliverrahner oliverrahner reopened this Apr 6, 2020
@TravisBuddy
Copy link

Hey @oliverrahner,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ac23f4d0-77f2-11ea-8413-0deac8e9891c

@cpmeister cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label Apr 6, 2020
@fwolter
Copy link
Member

fwolter commented Sep 6, 2020

Is this still work in progress? Do you like to have it reviewed?

@oliverrahner
Copy link
Author

oliverrahner commented Sep 7, 2020 •
edited
Loading

I still think it would be valuable contribution. The reason why I never submitted this for review is that I have much trouble removing all Null-Value-Warnings. After spending days trying to do this I basically surrendered...

@fwolter
Copy link
Member

fwolter commented Sep 7, 2020

If you have any question don't hesitate to ask.

@oliverrahner
Copy link
Author

I need to fix some things because Enera changed their API last week, so maybe during this I'll come back to you ;)

@oliverrahner oliverrahner requested a review from a team as a code owner September 13, 2020 12:38
@oliverrahner oliverrahner force-pushed the enera-binding branch 2 times, most recently from da54872 to d6b4b07 Compare September 13, 2020 15:47
@oliverrahner
[enera] Updated to accomodate for changes introduced by Enera in 08/2020
ea1b004 
Signed-off-by: Oliver Rahner <oliver@rahner.me>
@openhab-bot
Copy link
Collaborator

Automatic code migration to openHAB 3 succeeded.

The resulting code can be found at https://ci.openhab.org/job/openHAB-Addons-Migration/27/artifact/bundles/.

You can download the migrated code from there and create a new PR against the master branch of the openhab-addons repo to contribute it for being included in openHAB 3.x.

Please see this issue about the details on how to proceed with your existing PR.

@kaikreuzer
Copy link
Member

Closing this PR as it is not in a mergeable state. Please follow the instructions to port this PR to the main branch for openHAB 3.

@kaikreuzer kaikreuzer closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oliverrahner @TravisBuddy @fwolter @openhab-bot @kaikreuzer @cpmeister