Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[neohub] bug fix for new hub firmware #7323

Merged
merged 3 commits into from
Apr 8, 2020
Merged

[neohub] bug fix for new hub firmware #7323

merged 3 commits into from
Apr 8, 2020

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Apr 8, 2020

Heatmiser recently released a new firmware version that produces broken JSON for some boolean state variables (it produces a JSON object format "OFFLINE":0 instead of "OFFLINE":false ). So I had to implement a custom NeohubBool class for these boolean state variables, together with a custom JSON deserializer for NeohubBool that can read and deserialize either "OFFLINE":0 or "OFFLINE":false versions.

@andrewfg
[neohub] new NeohubBool and NeohubBoolDeserializer classes
131b4da 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[neohub] implement NeohubBool and NeohubBoolDeserializer
5701992 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON ve…
97bb219 
…rsions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Apr 8, 2020
@andrewfg andrewfg requested a review from cpmeister April 8, 2020 15:13
cpmeister
cpmeister approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 415f6b6 into openhab:2.5.x Apr 8, 2020
@TravisBuddy
Copy link

Hey @andrewfg,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0f238d40-79ae-11ea-9e83-b31d17657a6d

@cpmeister cpmeister added this to the 2.5.4 milestone Apr 9, 2020
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@andrewfg @Hans-Reiner
[neohub] bug fix for new hub firmware (openhab#7323)
27ae55c 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@andrewfg
[neohub] bug fix for new hub firmware (openhab#7323)
1c57167 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@andrewfg andrewfg deleted the neohub-pr3 branch May 18, 2020 16:03
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@andrewfg @markus7017
[neohub] bug fix for new hub firmware (openhab#7323)
d426e02 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@andrewfg @LoungeFlyZ
[neohub] bug fix for new hub firmware (openhab#7323)
b45d431 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@andrewfg @J-N-K
[neohub] bug fix for new hub firmware (openhab#7323)
ef13305 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@andrewfg @CSchlipp
[neohub] bug fix for new hub firmware (openhab#7323)
64a809a 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@andrewfg
[neohub] bug fix for new hub firmware (openhab#7323)
a57bfa6 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@andrewfg
[neohub] bug fix for new hub firmware (openhab#7323)
7028d60 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@andrewfg
[neohub] bug fix for new hub firmware (openhab#7323)
9fa7df9 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@andrewfg
[neohub] bug fix for new hub firmware (openhab#7323)
7d9d915 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@andrewfg @DaanMeijer
[neohub] bug fix for new hub firmware (openhab#7323)
620c452 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@andrewfg @markus7017
[neohub] bug fix for new hub firmware (openhab#7323)
05a7d7a 
* [neohub] new NeohubBool and NeohubBoolDeserializer classes
* [neohub] implement NeohubBool and NeohubBoolDeserializer
* [neohub] test NeohubBool, NeohubBoolDeserializer with old/new JSON versions

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewfg @TravisBuddy @cpmeister