[chromecast] Refactoring of binding #7367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
reviewed
Apr 14, 2020
...romecast/src/main/java/org/openhab/binding/chromecast/internal/utils/ByteArrayFileCache.java
Outdated
Show resolved
Hide resolved
cweitkamp
commented
Apr 14, 2020
| @@ -17,6 +17,8 @@ thing-type.config.chromecast.device.ipAddress.label = IP-Adresse | |||
| thing-type.config.chromecast.device.ipAddress.description = Lokale IP-Adresse oder Hostname des Chromecast Ger�tes. | |||
| thing-type.config.chromecast.device.port.label = Port | |||
| thing-type.config.chromecast.device.port.description = Port des Chromecast Ger�tes. | |||
| thing-type.config.chromecast.device.refreshRate.label = Aktualisierungsintervall | |||
| thing-type.config.chromecast.device.refreshRate.description = Intervall zur Aktualisierung des Chromecast Ger�tes. | |||
|
|
|||
| # channel types | |||
| channel-type.kodi.stop.label = Stop | |||
There was a problem hiding this comment.
I should change this mistake too.
cpmeister
requested changes
Apr 14, 2020
...ng.chromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastAudioSink.java
Outdated
Show resolved
Hide resolved
...ng.chromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastAudioSink.java
Show resolved
Hide resolved
...ng.chromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastCommander.java
Show resolved
Hide resolved
...hromecast/src/main/java/org/openhab/binding/chromecast/internal/ChromecastStatusUpdater.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/binding/chromecast/internal/discovery/ChromecastDiscoveryParticipant.java
Outdated
Show resolved
Hide resolved
...romecast/src/main/java/org/openhab/binding/chromecast/internal/utils/ByteArrayFileCache.java
Outdated
Show resolved
Hide resolved
Comment on lines
+291
to
+298
| final MessageDigest md = MessageDigest.getInstance(MD5_ALGORITHM); | ||
| return String.format("%032x", new BigInteger(1, md.digest(key.getBytes(StandardCharsets.UTF_8)))); |
There was a problem hiding this comment.
Surely there are simpler ways to generate a unique file name than using an MD5 hash. Wouldn't the hashcode of the key suffice?
There was a problem hiding this comment.
Since you use this code in other bindings I'm assuming that it wouldn't be worth changing this...
There was a problem hiding this comment.
Changing it here should be okay. But changing it in other bindings will result in "data loss" (data ist still there but not taken into account anymore). I am pretty sure there is no better way than using String.hashCode() method at all.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-chromecast-refactoring
branch
from
cda5702
to
41c8294
Compare
cweitkamp
added
the
enhancement
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* Refactoring of binding * Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stuff lying around in my branches.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de