Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DWDPollenflug] Small code improvments #7395

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[DWDPollenflug] Small code improvments #7395

merged 2 commits into from
Apr 16, 2020

Conversation

DerOetzi
Copy link
Contributor

Did some small improvements I have learned, while transfering to new CoronaStats binding (see #7358)

Biggest change is the new DiscoveryService for bridge thing

Johannes DerOetzi Ott added 2 commits April 16, 2020 23:34
[DWDPollenflug] Small refactoring and improvments
fdb4179 
Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
[DWDPollenflug] Added DiscoveryService
fabdff9 
Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
@TravisBuddy
Copy link

Travis tests were successful

Hey @DerOetzi,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 16, 2020
@cpmeister cpmeister merged commit 61019cc into openhab:2.5.x Apr 16, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 16, 2020
@DerOetzi DerOetzi deleted the dwdpollenflug branch April 26, 2020 20:58
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@DerOetzi
[DWDPollenflug] Small code improvments (openhab#7395)
822b6e1 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@DerOetzi @markus7017
[DWDPollenflug] Small code improvments (openhab#7395)
e68b1eb 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@DerOetzi @LoungeFlyZ
[DWDPollenflug] Small code improvments (openhab#7395)
6edfdfd 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@DerOetzi @J-N-K
[DWDPollenflug] Small code improvments (openhab#7395)
6b3aad5 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@DerOetzi @CSchlipp
[DWDPollenflug] Small code improvments (openhab#7395)
6414587 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@DerOetzi @andrewfg
[DWDPollenflug] Small code improvments (openhab#7395)
7dffe7b 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@DerOetzi @andrewfg
[DWDPollenflug] Small code improvments (openhab#7395)
7bcc1f5 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@DerOetzi @andrewfg
[DWDPollenflug] Small code improvments (openhab#7395)
cc817fc 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@DerOetzi @andrewfg
[DWDPollenflug] Small code improvments (openhab#7395)
8d567e1 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@DerOetzi @DaanMeijer
[DWDPollenflug] Small code improvments (openhab#7395)
7bf97c1 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@DerOetzi @markus7017
[DWDPollenflug] Small code improvments (openhab#7395)
73f680e 
* [DWDPollenflug] Small refactoring and improvements
* [DWDPollenflug] Added DiscoveryService

Signed-off-by: Johannes DerOetzi Ott <info@johannes-ott.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@DerOetzi @TravisBuddy @cpmeister