Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgwebos] Delay subscription of channel #7401

Merged
merged 2 commits into from
Apr 17, 2020
Merged

[lgwebos] Delay subscription of channel #7401

merged 2 commits into from
Apr 17, 2020

Conversation

sprehn
Copy link
Contributor

@sprehn sprehn commented Apr 17, 2020

Addresses issue #7243.

without the delay it can happen, that we request a subscription, but livetv is not yet ready to respond. Instead we get this error:

2020-04-17 18:11:11.767 [DEBUG] [.lgwebos.internal.BaseChannelHandler] - Subscribed org.openhab.binding.lgwebos.internal.TVControlChannel on Thing: lgwebos:WebOSTV:6da62662-1369-a82d-95c7-353c235ed503
2020-04-17 18:11:11.816 [DEBUG] [bos.internal.handler.LGWebOSTVSocket] - Error: {"type":"error","id":9,"error":"500 Application error","payload":{"returnValue":false,"errorCode":"BROADCAST_ERROR_1003","errorText":"No information"}}
2020-04-17 18:11:11.817 [DEBUG] [ng.lgwebos.internal.TVControlChannel] - Error in retrieving channel: 500 Application error.

the delay fixes the issue

@sprehn
Delay subscription of channel. Addresses issue openhab#7243.
9da3527 
Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
@sprehn sprehn requested a review from lolodomo April 17, 2020 18:03
@TravisBuddy
Copy link

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@sprehn
Calling stopChannelSubscriptionJob() in dispose()
ace67cb 
Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
@TravisBuddy
Copy link

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Apr 17, 2020
lolodomo
lolodomo approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpmeister
cpmeister approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 37f1096 into openhab:2.5.x Apr 17, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 17, 2020
@sprehn sprehn deleted the 2.5.x-AppSubscription branch April 17, 2020 22:14
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@sprehn
[lgwebos] Delay subscription of channel (openhab#7401)
35fc1a5 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@sprehn @markus7017
[lgwebos] Delay subscription of channel (openhab#7401)
49ab6c2 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@sprehn @LoungeFlyZ
[lgwebos] Delay subscription of channel (openhab#7401)
43b1a9f 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@sprehn @J-N-K
[lgwebos] Delay subscription of channel (openhab#7401)
9d11656 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@sprehn @CSchlipp
[lgwebos] Delay subscription of channel (openhab#7401)
5fb0ed6 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@sprehn @andrewfg
[lgwebos] Delay subscription of channel (openhab#7401)
fdc8e1c 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@sprehn @andrewfg
[lgwebos] Delay subscription of channel (openhab#7401)
338587c 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@sprehn @andrewfg
[lgwebos] Delay subscription of channel (openhab#7401)
b1641c0 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@sprehn @andrewfg
[lgwebos] Delay subscription of channel (openhab#7401)
6b8a3e9 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@sprehn @DaanMeijer
[lgwebos] Delay subscription of channel (openhab#7401)
7efd6c1 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@sprehn @markus7017
[lgwebos] Delay subscription of channel (openhab#7401)
de656e8 
* Delay subscription of channel. Addresses issue openhab#7243.
* Calling stopChannelSubscriptionJob() in dispose()

Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sprehn @TravisBuddy @cpmeister @lolodomo