-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] fix parsing issue #7456
Merged
Merged
[miio] fix parsing issue #7456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Travis tests were successfulHey @marcelrv, |
cpmeister
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cpmeister
added
the
bug
An unexpected problem or unintended behavior of an add-on
label
Apr 23, 2020
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Eugen Freiter <freiter@gmx.de>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
As we don't really know the data types of these variables. https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333 Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com