Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] fix parsing issue #7456

Merged
merged 1 commit into from
Apr 23, 2020
Merged

[miio] fix parsing issue #7456

merged 1 commit into from
Apr 23, 2020

Conversation

marcelrv
Copy link
Contributor

As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Apr 23, 2020
@cpmeister cpmeister merged commit 2800b48 into openhab:2.5.x Apr 23, 2020
@cpmeister cpmeister added this to the 2.5.5 milestone Apr 23, 2020
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@marcelrv marcelrv deleted the miio-uidFix branch May 7, 2020 20:39
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
As we don't really know the data types of these variables.
https://community.openhab.org/t/uid-thats-higher-than-max-int32-causes-exception/97333


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants