[pjlink] Null characters fix #7462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
Travis tests were successfulHey @nils, |
nils
added
the
external bug
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Signed-off-by: Eugen Freiter <freiter@gmx.de>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* use MessageFormat where applicable * remove null characters from response see openhab#6725 Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least improves the situation reported in issue #6725.
Some PJLink devices seem to be not fully compliant, and send \0 bytes in front of messages.
The device does seem to have other issues, but this one is rather easy to fix by removing leading \0 bytes and also does not have negative impact on compliant devices.