Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coronastats] Use QuantityType instead of plain DecimalType #7477

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Apr 25, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @kaikreuzer,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Should you also specify a pattern or is that not needed?

@kaikreuzer
Copy link
Member Author

No, those are all unitless integers, no need for a format.

@cpmeister cpmeister merged commit 642613f into openhab:2.5.x Apr 25, 2020
@cpmeister cpmeister added this to the 2.5.5 milestone Apr 25, 2020
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
…7477)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
…7477)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…7477)

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@kaikreuzer kaikreuzer deleted the coronadim branch November 13, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants