Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insteon] Added support to 2472D OutletLinc Dimmer for LED On/Off, LED Brightness, Local Ramp Rate and Beep #7490

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

tommycw1
Copy link

Recently bought one of these and these features were not supported by OH.

Interesting note, I suspected this would act just like a 2477D dimmer and it mostly does, but it does not respond to local on-level changes so I left that feature out. You can set the local on-level and reading the Status, you can see it takes the change, but pressing the hardware button still goes to full brightness - disregarding the OL setting.

This is for Feature Request: #7469

…ss, Local Ramp Rate and Beep

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>

Small format change from Spotless

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
@robnielsen robnielsen added the enhancement An enhancement or new feature for an existing add-on label Apr 27, 2020
@tommycw1
Copy link
Author

@robnielsen next time I'll try using feature branches to avoid PRs getting closed when I have to catch up to upstream as you suggested in:
#7481

Sorry about the confusion. I'm pretty new to using git.

Also wanted to note I did run mvn spotless:apply as you suggested before committing.

Copy link
Contributor

@robnielsen robnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisBuddy
Copy link

Travis tests were successful

Hey @tommycw1,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister changed the title Added support to 2472D OutletLinc Dimmer for LED On/Off, LED Brightness, Local Ramp Rate and Beep [insteon] Added support to 2472D OutletLinc Dimmer for LED On/Off, LED Brightness, Local Ramp Rate and Beep Apr 27, 2020
@cpmeister cpmeister merged commit 0671c4f into openhab:2.5.x Apr 27, 2020
@cpmeister cpmeister added this to the 2.5.5 milestone Apr 27, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
…D Brightness, Local Ramp Rate and Beep (openhab#7490)

Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants