Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial version of a Onkyo binding #768

Merged
merged 8 commits into from
Jul 25, 2016
Merged

initial version of a Onkyo binding #768

merged 8 commits into from
Jul 25, 2016

Conversation

pail23
Copy link
Contributor

@pail23 pail23 commented Mar 27, 2016

This is a port of the openhab1 Onkyo binding to openhab2. Not all features of the openhab1 binding are available yet.

Current features include:

  • Power on/off
  • Volume
  • Select input
  • Mute
  • Player, Album, Artist and Title for the network or USB input of the Onkyo receiver
  • Discovery of Onkyo Receivers

Uses the protocol implementation of the original openhab1 Onkyo binding,

@kaikreuzer kaikreuzer added the new binding If someone has started to work on a binding. For a new binding PR. label Mar 27, 2016
kaikreuzer
kaikreuzer reviewed Jul 20, 2016
View reviewed changes
addons/binding/org.openhab.binding.onkyo/ESH-INF/thing/thing-types.xml
<parameter name="ipAddress" type="text" required="true">
<label>IP or Host Name</label>
<description>The IP or host name of the Onkyo Receiver
</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the line break

@kaikreuzer
Copy link
Member

Hi @pail23, many thanks for this contribution and sorry that it took me soooo long to review, although there are really only some minor remarks.

Not all features of the openhab1 binding are available yet.

Could you elaborate on what is missing? Do you plan to get it on par before we merge it?

@kaikreuzer kaikreuzer added the awaiting feedback Awaiting feedback from the pull request author label Jul 20, 2016
@tavalin
Copy link

tavalin commented Jul 20, 2016 •
edited
Loading

@pail23 is there a reason why approving the new discovered Thing turns the AVR off? That was quite annoying.

However apart from the previous comments it works well. 👍

Edit: After a restart of OH the AVR turns off again so I presume this is being caused early on in the Thing lifecycle, maybe in the OnkyoHandler.

@pail23
Copy link
Contributor Author

pail23 commented Jul 23, 2016

@tavalin: I think I have fixed this issue. Could you please test again and provide feedback?
@kaikreuzer : Thanks a lot for the review. I have adjusted the code according your comments.

The following features are missing at the moment:

  • Zone 2 and Zone 3: I dont use Zone2/3. Therefore I would not be able to test it
  • Video Wide setting: My receiver seams not to support this setting.
  • The OH1 bindung allows to send raw commands to the receiver. I don't know if this really makes sense in OH2 and how to map this to the channel concept.

I propose the merge the binding with the current feature set. If somebody else has a setup with zone 2/3 or a receiver which supports Video Wide setting, the implementation can still be extended.

@tavalin
Copy link

tavalin commented Jul 23, 2016

@pail23 Tested the latest commits and restarted OH twice, no change in AVR states this time 👍

@pail23
documentation update and typo fix
0182a49 
Signed-off-by: Paul Frank <pail@gmx.net>
@kaikreuzer kaikreuzer removed the awaiting feedback Awaiting feedback from the pull request author label Jul 25, 2016
@kaikreuzer kaikreuzer added this to the 2.0.0.b4 milestone Jul 25, 2016
@kaikreuzer
Copy link
Member

Many thanks @pail23!

@kaikreuzer kaikreuzer merged commit fa67343 into openhab:master Jul 25, 2016
cdjackson added a commit to cdjackson/openhab2-addons that referenced this pull request Jul 28, 2016
@cdjackson
Merge branch 'master' into zwave-association-consolidation
6bfb57e 
* master: (44 commits)
  ZWave fix Barrier Operator converter (openhab#1155)
  Added Groovy Eclipse compiler to master pom. (openhab#1141)
  added HD Powerview binding to build
  Initial contribution of HD PowerView binding (openhab#660)
  ZWave database update (openhab#1153)
  added Onkyo binding to build
  initial version of a Onkyo binding (openhab#768)
  Fix initialization and add thing properties (openhab#1127)
  ZWave: Add extra debugging when updating properties. (openhab#1147)
  ZWave database update (openhab#1148)
  fixed compilation error due to changed ESH API (openhab#1146)
  ZWave database updates (openhab#1145)
  Add example things definition (openhab#1144)
  ignore commands other than ON/OFF
  applied code formatter
  Meteostick binding (openhab#455)
  Fix for multiple tags and HomeKit (openhab#1138)
  ZWave database update (openhab#1136)
  Fix wording and typos. Alphabetise supported channel list. (openhab#1134)
  ZWave database updates (openhab#1132)
  ...

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

# Conflicts:
#	addons/binding/org.openhab.binding.zwave/src/main/java/org/openhab/binding/zwave/handler/ZWaveThingHandler.java
cdjackson added a commit to cdjackson/openhab2-addons that referenced this pull request Aug 6, 2016
@cdjackson
Merge branch 'master' into zigbee
a480e15 
* master: (257 commits)
  Delete pom.xml.orig
  Update README.md
  Remove ZWave binding (openhab#1169)
  Update README.md (openhab#1168)
  ZWave check that serial port is open before sending data (openhab#1167)
  ZWave change polling to use BigDecimal rather than Integer (openhab#1166)
  ZWave fix processing of alarm supported report (openhab#1165)
  ZWave add network update method (openhab#1162)
  Zwave association refactor and consolidation (openhab#893)
  Update README.md (openhab#1159)
  ZWave database update (openhab#1161)
  ZWave fix Barrier Operator converter (openhab#1155)
  Added Groovy Eclipse compiler to master pom. (openhab#1141)
  added HD Powerview binding to build
  Initial contribution of HD PowerView binding (openhab#660)
  ZWave database update (openhab#1153)
  added Onkyo binding to build
  initial version of a Onkyo binding (openhab#768)
  Fix initialization and add thing properties (openhab#1127)
  ZWave: Add extra debugging when updating properties. (openhab#1147)
  ...

# Conflicts:
#	addons/binding/pom.xml
doubled-ca pushed a commit to doubled-ca/openhab-addons that referenced this pull request Aug 14, 2016
@pail23 @doubled-ca
initial version of a Onkyo binding (openhab#768)
33d243a 
* initial version of a Onkyo binding

Signed-off-by: Paul Frank <pail@gmx.net>
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
@cweitkamp @kaikreuzer
Updated xml schema definition locations to openhab (openhab#768)
92e58eb 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
2.0.0 beta4
Development

Successfully merging this pull request may close these issues.
3 participants
@pail23 @kaikreuzer @tavalin