[weatherunderground] Log URL with masked API key #7756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative to openhab#3990 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests were successfulHey @lolodomo, |
cpmeister
requested changes
May 23, 2020
.../java/org/openhab/binding/weatherunderground/internal/handler/WeatherUndergroundHandler.java
Show resolved
Hide resolved
cpmeister
approved these changes
May 23, 2020
cpmeister
requested changes
May 23, 2020
| @@ -553,7 +551,9 @@ private boolean updateWeatherData(Set<String> features) { | |||
| } | |||
|
|
|||
| urlStr = urlStr.replace("%QUERY%", StringUtils.trimToEmpty(config.location)); | |||
| logger.debug("URL = {}", urlStr); | |||
| logger.debug("URL = {}", urlStr.replace("%APIKEY%", "***")); | |||
There was a problem hiding this comment.
Suggested change
| logger.debug("URL = {}", urlStr.replace("%APIKEY%", "***")); | |
| if(logger.isDebugEnabled()){ | |
| logger.debug("URL = {}", urlStr.replace("%APIKEY%", "***")); | |
| } |
There was a problem hiding this comment.
What's the interest to add this test?
There was a problem hiding this comment.
Since users may not be interested in debug logging, and as such would be filtered out, you should try to minimize wasting computational resources on creating values to be logged.
In this case String.replace involves a search and replace, the result of which might not even be used. So in order to prevent unnecessary calls to this operation we just check if that logging level is even enabled in the first place.
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests were successfulHey @lolodomo, |
cpmeister
approved these changes
May 25, 2020
bodiroga
pushed a commit
to bodiroga/openhab-addons
that referenced
this pull request
May 26, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* [weatherunderground] Log URL with masked API key Relative to openhab#3990 * Add isDebugEnabled Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative to #3990
Signed-off-by: Laurent Garnier lg.hc@free.fr