[hue] Channel alert added for groups #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix openhab#7742 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
cpmeister
requested changes
May 27, 2020
| * This method will cancel previously scheduled alert item state | ||
| * restoration. | ||
| */ | ||
| private void cancelScheduledFuture() { |
There was a problem hiding this comment.
You should call this when disposing this handler as well.
There was a problem hiding this comment.
Yes, you're right.
I have done a copy/paste from the hue light handler and this was missing in this handler too.
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests have failedHey @lolodomo, |
cpmeister
approved these changes
May 27, 2020
cpmeister
added
the
enhancement
Dries-Vandenneucker
added a commit
to Dries-Vandenneucker/openhab-addons
that referenced
this pull request
May 31, 2020
* 2.5.x: (174 commits) [hpprinter] Add additional data points and refactoring (openhab#7805) [neohub] new/legacy API; null annotations; enhancements; bugs; logging (openhab#7767) [meteoalerte] Initial contribution (openhab#7200) [lgwebos] Console command to show the access key (openhab#7801) [hue] Refactored state handling and fix polling after command (openhab#7518) [telegram] add attachment URL (openhab#7816) [siemensrds] readme adjusted to match openhab#7814 (openhab#7819) [lametrictime] correctly parse response (openhab#7818) [Seneye] Bug fix for using Pond or Home sensors. (openhab#7797) [siemensrds] apply UoM quantityType percent for relative humidity (openhab#7814) [alarmdecoder] Add vzone thing for virtual zone control (openhab#7800) [hue] Channel alert added for groups (openhab#7810) [hue] Keep compatibility with hue emulation for groups (openhab#7809) [dscalarm] Bridge/things management refactored (openhab#7748) [avmfritz] Add link to Fensterkontakt (magnetisch) to docs (openhab#7806) [deconz] add light/blind support and additional sensors (openhab#7608) [homekit] add support for min/max values for temperature (openhab#7782) [tesla] Use CXF JAX-RS client builder, if available (openhab#7804) [mqtt.homie] Improve Homie discovery time (openhab#7760) [siemensrds] null annotations; JUnit; UoM; enhancements; bug; refactoring; logging (openhab#7769) ...
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de>
|
Should the documentation be updated with group as a supported thing type? |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* [hue] Channel alert added for groups Fix openhab#7742 * Call cancelSceduledFuture in dispo() Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7742
Signed-off-by: Laurent Garnier lg.hc@free.fr