[modbus][sunspec] Fixed type and scale errors on acc32 fields #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
Travis tests were successfulHey @mrbig, |
|
I wonder why it doesn't list you as codeowner of the files in this PR... |
Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
Fixed the alphabetic order. Seems like to me that this fixed it. |
Travis tests were successfulHey @mrbig, |
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…b#7826) * [modbus][sunspec] Fixed type and scale errors on acc32 fields ACC32 fields were mistakenly parsed as unsigned int instead of signed default scale value is 10^0=1 now scaling was missing for 10^1 fields * [modbus][sunspec] Changed CODEOWNERS order Seems like mrbig is not recognized as codeowner by github. Trying to fix the alphabetic order to see if this helps Signed-off-by: Nagy Attila Gabor <mrbig@sneaker.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some scaling errors in the modbus.sunspec bundle: