Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nibeheatpump] Add new registers 49008 and 49009 #7845

Merged
merged 3 commits into from
Jun 3, 2020
Merged

[nibeheatpump] Add new registers 49008 and 49009 #7845

merged 3 commits into from
Jun 3, 2020

Conversation

Yogi4301
Copy link

@Yogi4301 Yogi4301 commented Jun 3, 2020

Added registers 49008 and 49009 for Nibe Model F1245

@Yogi4301
Update f1x45-channel-groups.xml
c383c7d 
Add registers 49008 and 49009
@Yogi4301
Update f1x45-types.xml
ebb6bf0 
Add registers 49008 nd 49009
@Yogi4301
Update F1X45.java
b653052 
ADd register 49008 and 49009
@TravisBuddy
Copy link

Travis tests were successful

Hey @Yogi4301,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jun 3, 2020
@cpmeister
Copy link
Contributor

cpmeister commented Jun 3, 2020 •
edited
Loading

Can you add a comment here with your sign-off? It would be in the format of:
Signed-off-by: firstname lastname <emailaddress>

Thanks!

@Yogi4301
Copy link
Author

Yogi4301 commented Jun 3, 2020

Signed-off-by: Joerg Schottmueller joerg.schottmueller@online.de

@cpmeister
Copy link
Contributor

Manually checked sign-off

@cpmeister cpmeister merged commit aceff74 into openhab:2.5.x Jun 3, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 3, 2020
@cpmeister
Copy link
Contributor

Thanks for taking the time to make this contribution!

@Yogi4301 Yogi4301 deleted the Yogi4301-patch-1 branch June 3, 2020 17:06
@paulianttila
Copy link
Contributor

@Yogi4301, thanks for the PR. Could you also update README.md accordingly?

J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@Yogi4301 @J-N-K
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
3e7e59b 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@Yogi4301 @CSchlipp
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
2bcbb4d 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Yogi4301 @andrewfg
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
9b0aac5 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Yogi4301 @andrewfg
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
7b797a1 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Yogi4301 @andrewfg
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
34ff76e 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Yogi4301 @andrewfg
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
71cdf34 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Yogi4301 @DaanMeijer
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
3950820 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Yogi4301 @markus7017
[nibeheatpump] Add new registers 49008 and 49009 (openhab#7845)
351db36 
* Update f1x45-channel-groups.xml
* Update f1x45-types.xml
* Update F1X45.java

Signed-off-by: Joerg Schottmueller <joerg.schottmueller@online.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Yogi4301 @TravisBuddy @cpmeister @paulianttila