Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neohub] added image to readme #7861

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jun 5, 2020

Added an image to the ReadMe file

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@TravisBuddy
Copy link

Travis tests were successful

Hey @andrewfg,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 46fef52 into openhab:2.5.x Jun 8, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 8, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg deleted the neohub-wip branch December 22, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants