[netatmo] Consider TimeZoneProvider

[lolodomo]

Signed-off-by: Laurent Garnier lg.hc@free.fr

[TravisBuddy]

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[cpmeister]

Not sure I'm comfortable with adding static variables if you don't have to. But I can see why you would want to.
@J-N-K What is your opinion on this?

[lolodomo]

I can avoid it but I should then pass TimeZoneProvier as parameter to a lot of handler classes.
If you prefer, I can do it.
Note that the astro binding uses this way with the global variable.

[TravisBuddy]

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[lolodomo]

As you can see, to avoid the global variable, it required many more changes.

Note that I have not tested the changes.

[cpmeister]

LGTM

[cpmeister]

Yeah, sorry about having you go through that. Static fields can make some things so much more convenient but they can also cause unforeseen problems in what should be a modular environment. Thank you.