Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[samsungtv] Make use of representation property in discovery #7936

Merged
merged 1 commit into from
Jun 18, 2020
Merged

[samsungtv] Make use of representation property in discovery #7936

merged 1 commit into from
Jun 18, 2020

Conversation

t2000
Copy link
Contributor

@t2000 t2000 commented Jun 18, 2020

Contributes to #6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller github@stefantriller.de

@t2000
[samsungtv] Make use of representation property in discovery
0dec558 
Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
@t2000 t2000 requested a review from paulianttila as a code owner June 18, 2020 15:56
@TravisBuddy
Copy link

Travis tests were successful

Hey @t2000,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jun 18, 2020
@cpmeister cpmeister merged commit 8cec10f into openhab:2.5.x Jun 18, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 18, 2020
@t2000 t2000 deleted the samsungTvRepresentationProperty branch July 8, 2020 16:49
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@t2000 @knikhilwiz
[samsungtv] Make use of representation property in discovery (openhab…
cd5e49c 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@t2000 @CSchlipp
[samsungtv] Make use of representation property in discovery (openhab…
7dddbd8 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@t2000 @andrewfg
[samsungtv] Make use of representation property in discovery (openhab…
44fd39e 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@t2000 @andrewfg
[samsungtv] Make use of representation property in discovery (openhab…
995da51 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@t2000 @andrewfg
[samsungtv] Make use of representation property in discovery (openhab…
345e16b 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@t2000 @andrewfg
[samsungtv] Make use of representation property in discovery (openhab…
9b2d523 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@t2000 @DaanMeijer
[samsungtv] Make use of representation property in discovery (openhab…
d2c69e4 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@t2000 @markus7017
[samsungtv] Make use of representation property in discovery (openhab…
774dd2a 
…#7936)

Contributes to openhab#6317 and should hide a result if there is already a thing
defined which does not have the same ThingUID but points to the same TV.

Signed-off-by: Stefan Triller <github@stefantriller.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
3 participants
@t2000 @TravisBuddy @cpmeister