Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] The lastEvent is detected/compared incorrectly - Line-endings fixed (#7963) #7966

Merged
merged 8 commits into from
Jun 20, 2020
Merged

[netatmo] The lastEvent is detected/compared incorrectly - Line-endings fixed (#7963) #7966

merged 8 commits into from
Jun 20, 2020

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Jun 20, 2020

Line-endings fixed for a new file...

@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister merged commit 3e7b97e into openhab:2.5.x Jun 20, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 20, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@Novanic @knikhilwiz
Line-endings fixed... (openhab#7966)
f51b716 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@Novanic @CSchlipp
Line-endings fixed... (openhab#7966)
1fc8fc4 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Novanic @MPH80
Line-endings fixed... (openhab#7966)
df90870 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
Line-endings fixed... (openhab#7966)
1fb4280 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
Line-endings fixed... (openhab#7966)
b30cd82 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
Line-endings fixed... (openhab#7966)
164ef2b 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
Line-endings fixed... (openhab#7966)
7022896 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Novanic @DaanMeijer
Line-endings fixed... (openhab#7966)
0fe74bd 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Novanic @markus7017
Line-endings fixed... (openhab#7966)
ddbea6e 
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Novanic @TravisBuddy @cpmeister @sstrohschein