Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homekit] add support for group switches #7967

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

yfre
Copy link
Contributor

@yfre yfre commented Jun 20, 2020

as discussed here
https://community.openhab.org/t/problems-with-homekit-switchable-feature-on-switch-groups/100702
and here
https://community.openhab.org/t/homekit-could-not-find-existing-mac/100845/26

current HomeKit binding does not support groups with a base item, eg.

Group:Switch:OR(ON,OFF) gLights "ALL Lights [%s]"	{homekit="Lighting"}
Switch Light_1 "Light 1 [%s]"  (gLights,) {homekit="Lighting"}
Switch Light_2 "Light 2 [%s]"  (gLights,) {homekit="Lighting"}

it would create only one accessory - for the group but not for light_1 and light_2. the logic is following: if an item is part of bigger group with homekit tag, then the item is a characteristic of this homekit accessory/group.

this PR fix this issue by ignoring groups with base item.

Signed-off-by: Eugen Freiter freiter@gmx.de

Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre changed the title add suport for group switches [homekit] add support for group switches Jun 20, 2020
@yfre yfre added the bug An unexpected problem or unintended behavior of an add-on label Jun 20, 2020
@openhab openhab deleted a comment from TravisBuddy Jun 21, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @yfre,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@openhab openhab deleted a comment from TravisBuddy Jun 22, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @yfre,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit f83ed50 into openhab:2.5.x Jun 24, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jun 24, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@yfre yfre deleted the fix_group_with_base_item branch November 15, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants