Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lametrictime] Fix the failing tests on Windows #7990

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[lametrictime] Fix the failing tests on Windows #7990

merged 1 commit into from
Jun 23, 2020

Conversation

lolodomo
Copy link
Contributor

Fix #7979

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[lametrictime] Fix the failing tests on Windows
8e3a112 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from syphr42 as a code owner June 23, 2020 16:02
@lolodomo lolodomo requested a review from wborn June 23, 2020 16:03
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

wborn
wborn approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 2c45d35 into openhab:2.5.x Jun 23, 2020
@lolodomo lolodomo deleted the lametrictime_tests branch June 23, 2020 19:47
@cpmeister cpmeister added this to the 2.5.7 milestone Jun 23, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@lolodomo @knikhilwiz
[lametrictime] Fix the failing tests on Windows (openhab#7990)
3d5d2a0 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[lametrictime] Fix the failing tests on Windows (openhab#7990)
c91e258 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@lolodomo @MPH80
[lametrictime] Fix the failing tests on Windows (openhab#7990)
e79ce5e 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lametrictime] Fix the failing tests on Windows (openhab#7990)
9307505 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lametrictime] Fix the failing tests on Windows (openhab#7990)
6cd8d13 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lametrictime] Fix the failing tests on Windows (openhab#7990)
82a0b67 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[lametrictime] Fix the failing tests on Windows (openhab#7990)
34df0bd 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[lametrictime] Fix the failing tests on Windows (openhab#7990)
d2ce3f6 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[lametrictime] Fix the failing tests on Windows (openhab#7990)
3a3fd70 
Fix openhab#7979

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@syphr42 syphr42 Awaiting requested review from syphr42 syphr42 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.

[lametrictime] Tests failing
4 participants
@lolodomo @TravisBuddy @wborn @cpmeister