Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Null annotations Part 2 of 3 #8019

Merged
merged 3 commits into from
Jun 28, 2020
Merged

[netatmo] Null annotations Part 2 of 3 #8019

merged 3 commits into from
Jun 28, 2020

Conversation

lolodomo
Copy link
Contributor

Related to #7913

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[netatmo] Null annotations Part 2 of 3
194665a 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
Check that bridge handler is not null
351c50f 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
Update signature of method getMeasurements
7b61c00 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

wborn
wborn approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@wborn wborn merged commit 0d57db5 into openhab:2.5.x Jun 28, 2020
@lolodomo lolodomo deleted the netatmo_null2 branch June 28, 2020 07:03
@cpmeister cpmeister added this to the 2.5.7 milestone Jun 28, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@lolodomo @knikhilwiz
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
0d7ed3f 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
16cfca6 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@lolodomo @MPH80
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
ba104fe 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
fb80f17 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
b0e3c92 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
79691d2 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
9cc6625 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
35b73db 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[netatmo] Null annotations Part 2 of 3 (openhab#8019)
cf1a3ee 
Related to openhab#7913

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinique clinique clinique approved these changes

@wborn wborn wborn approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
5 participants
@lolodomo @TravisBuddy @clinique @wborn @cpmeister