Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tplinksmarthome] Added support for KP105 #8023

Merged
merged 2 commits into from
Jun 28, 2020
Merged

[tplinksmarthome] Added support for KP105 #8023

merged 2 commits into from
Jun 28, 2020

Conversation

mdjward
Copy link

@mdjward mdjward commented Jun 27, 2020

This adds support for the KP105 slim smart plug (tested with the UK edition v1.0.5 Build 191209 Rel.094735).

@mdjward mdjward requested a review from Hilbrand as a code owner June 27, 2020 23:32
@TravisBuddy
Copy link

Travis tests were successful

Hey @mdjward,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mdjward
[tplinksmarthome] Added support for KP105
1b55e9d 
Signed-off-by: Matt Ward <dev@mattdw.eu>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mdjward,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand requested changes Jun 28, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, only a small issue. Can you add the device to the led channel in the channel table in the readme.md.

@mdjward
Add LED table entry for KP105.
8fc847f 
Signed-off-by: Matt Ward <matt.ward@lendable.co.uk>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mdjward,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mdjward mdjward requested a review from Hilbrand June 28, 2020 11:55
Hilbrand
Hilbrand approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit ac220fc into openhab:2.5.x Jun 28, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jun 28, 2020
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Jun 28, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@mdjward @knikhilwiz
[tplinksmarthome] Added support for KP105 (openhab#8023)
898e79e 
Signed-off-by: Matt Ward <dev@mattdw.eu>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@mdjward @CSchlipp
[tplinksmarthome] Added support for KP105 (openhab#8023)
6b01ab0 
Signed-off-by: Matt Ward <dev@mattdw.eu>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@mdjward @MPH80
[tplinksmarthome] Added support for KP105 (openhab#8023)
6c328c4 
Signed-off-by: Matt Ward <dev@mattdw.eu>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mdjward @andrewfg
[tplinksmarthome] Added support for KP105 (openhab#8023)
4e2bfd0 
Signed-off-by: Matt Ward <dev@mattdw.eu>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mdjward @andrewfg
[tplinksmarthome] Added support for KP105 (openhab#8023)
defaffc 
Signed-off-by: Matt Ward <dev@mattdw.eu>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mdjward @andrewfg
[tplinksmarthome] Added support for KP105 (openhab#8023)
bf1eea4 
Signed-off-by: Matt Ward <dev@mattdw.eu>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mdjward @andrewfg
[tplinksmarthome] Added support for KP105 (openhab#8023)
a695e0a 
Signed-off-by: Matt Ward <dev@mattdw.eu>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@mdjward @DaanMeijer
[tplinksmarthome] Added support for KP105 (openhab#8023)
29eb60b 
Signed-off-by: Matt Ward <dev@mattdw.eu>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@mdjward @markus7017
[tplinksmarthome] Added support for KP105 (openhab#8023)
1784b20 
Signed-off-by: Matt Ward <dev@mattdw.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mdjward @TravisBuddy @Hilbrand @cpmeister