[valloxmv] fix possible resource leak #8035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
12 tasks
Travis tests were successfulHey @J-N-K, |
|
Is closing each time too agressive? |
bjoernbrings
approved these changes
Jun 28, 2020
|
Depends. In general I would say that keeping the session is valid, saves some resources and could be used to avoid polling, if supported by the other side. OTOH, It seems to be not too frequent, so I'm ok with it. |
|
I think this one is ready for a merge ? |
kaikreuzer
approved these changes
Jul 12, 2020
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8027
This is an interesting one. It closes the websocket immediately after each request.
Signed-off-by: Jan N. Klug jan.n.klug@rub.de