Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Avoid updating the inbox at each poll #8066

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 4, 2020

Fix #8065

Signed-off-by: Laurent Garnier lg.hc@free.fr

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from cweitkamp as a code owner July 4, 2020 09:18
@TravisBuddy
Copy link

Travis tests have failed

Hey @lolodomo,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 4, 2020

Note that with this change, if the user removes an entry from the inbox, the binding will not add it again at the next poll. It will appear again only after a search requested by the user (in Paper UI) or a OH restart. By the way, that makes sense.

Copy link
Contributor

@DerOetzi DerOetzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 6, 2020

Need a rebuild

@lolodomo lolodomo closed this Jul 6, 2020
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 6, 2020

Rebuild

@lolodomo lolodomo reopened this Jul 6, 2020
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 7, 2020

@openhab/add-ons-maintainers : could you please review and merge this small PR ?

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 2.5.7 milestone Jul 7, 2020
@cweitkamp cweitkamp merged commit 8d585d8 into openhab:2.5.x Jul 7, 2020
@lolodomo lolodomo deleted the hue_inbox branch July 7, 2020 18:53
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
- Avoid updating the inbox at each poll

Fix openhab#8065

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hue] Discovered things updated too much often in the inbox
4 participants