Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openweathermap] Do not update the discovery inbox while the location is unchanged #8078

Merged
merged 1 commit into from
Jul 7, 2020
Merged

[openweathermap] Do not update the discovery inbox while the location is unchanged #8078

merged 1 commit into from
Jul 7, 2020

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 5, 2020

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from cweitkamp as a code owner July 5, 2020 06:47
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Jul 5, 2020
@lolodomo lolodomo changed the title [openweathermap] Do not update the discovery inbox while the location is unchanged [WIP][openweathermap] Do not update the discovery inbox while the location is unchanged Jul 5, 2020
@lolodomo
[openweathermap] Do not update the discovery inbox while the location…
8ad633b 
… is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo changed the title [WIP][openweathermap] Do not update the discovery inbox while the location is unchanged [openweathermap] Do not update the discovery inbox while the location is unchanged Jul 5, 2020
@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Jul 5, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cweitkamp
cweitkamp approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 2.5.7 milestone Jul 7, 2020
@cweitkamp cweitkamp merged commit 20571d8 into openhab:2.5.x Jul 7, 2020
@lolodomo lolodomo deleted the owm_discovery branch July 7, 2020 18:52
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@lolodomo @knikhilwiz
[openweathermap] Do not update the discovery inbox while the location…
78e988e 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[openweathermap] Do not update the discovery inbox while the location…
1187502 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@lolodomo @MPH80
[openweathermap] Do not update the discovery inbox while the location…
5528206 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[openweathermap] Do not update the discovery inbox while the location…
0adfc67 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[openweathermap] Do not update the discovery inbox while the location…
f864ff5 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[openweathermap] Do not update the discovery inbox while the location…
1281230 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[openweathermap] Do not update the discovery inbox while the location…
2e7c28c 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[openweathermap] Do not update the discovery inbox while the location…
836ede2 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[openweathermap] Do not update the discovery inbox while the location…
a2cea61 
… is unchanged (openhab#8078)

- Do not update the discovery inbox while the location is unchanged

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @TravisBuddy @cweitkamp