[lutron] Code clean-up to eliminate SCA warnings #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Adair <bob.github@att.net>
Travis tests have failedHey @bobadair, |
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Signed-off-by: Bob Adair <bob.github@att.net> Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Signed-off-by: Bob Adair <bob.github@att.net> Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Signed-off-by: Bob Adair <bob.github@att.net> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Bob Adair <bob.github@att.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit consists entirely of changes to field names made in order to eliminate warnings from the code analysis tool. Mainly it involved removing leading underscores and de-conflicting the results. It's been an on-going project to try to eliminate all SCA warnings, although there is still a long way to go when it comes to null annotations.
@tmrobert8 - It looks like you are the original contributor of the modified files (for GRX-PRG), so I'd appreciate it if you could review and/or test it out. I don't have the hardware to test it myself.