Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amazonechocontrol] remove deprecated discovery interfaces #8095

Merged
merged 3 commits into from
Jul 11, 2020
Merged

[amazonechocontrol] remove deprecated discovery interfaces #8095

merged 3 commits into from
Jul 11, 2020

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 9, 2020

See #7969 (comment)

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

@J-N-K
remove deprecated discovery interfaces
97f1969 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@J-N-K J-N-K requested a review from mgeramb as a code owner July 9, 2020 15:45
@J-N-K J-N-K changed the title remove deprecated discovery interfaces [amazonechocontrol] remove deprecated discovery interfaces Jul 9, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @J-N-K,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@J-N-K
Copy link
Member Author

J-N-K commented Jul 9, 2020

@cweitkamp this should fix the OH3 build again.

cweitkamp
cweitkamp requested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for talking care. Can you remove the imports too?

@J-N-K
address review comments
fe947c8 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@TravisBuddy
Copy link

Travis tests were successful

Hey @J-N-K,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cweitkamp
Copy link
Contributor

There is a second class impending and using them: AmazonEchoDiscovery.

cpmeister
cpmeister approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

There is a second class impending and using them: AmazonEchoDiscovery.

@J-N-K Can you make this change as well in this PR?

@J-N-K
Copy link
Member Author

J-N-K commented Jul 11, 2020

Ah. Didn't look at that file. It seems that the changes (which were done before) have been reverted accidentally in #7969.

@J-N-K
remove deprecated discovery interfaces
9b352b3 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@TravisBuddy
Copy link

Travis tests were successful

Hey @J-N-K,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @J-N-K,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cweitkamp
cweitkamp approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@cweitkamp cweitkamp merged commit 74dadc6 into openhab:2.5.x Jul 11, 2020
@J-N-K J-N-K deleted the aec-discovery branch July 11, 2020 13:09
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@J-N-K @knikhilwiz
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
68a451d 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 12, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@J-N-K @CSchlipp
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
87ea39a 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@J-N-K @MPH80
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
8012204 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@J-N-K @andrewfg
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
8fa3f10 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@J-N-K @andrewfg
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
160541f 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@J-N-K @andrewfg
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
09c2bc5 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@J-N-K @andrewfg
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
a399152 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@J-N-K @DaanMeijer
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
316a2c6 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@J-N-K @markus7017
[amazonechocontrol] Remove deprecated discovery interfaces (openhab#8095
cd63556 
)

* Remove deprecated discovery interfaces

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@cweitkamp cweitkamp cweitkamp approved these changes

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@J-N-K @TravisBuddy @cweitkamp @cpmeister