Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lutron] Deprecate ccopulsed and ccomaintained things #8109

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

bobadair
Copy link
Member

This commit deprecates the ccopulsed and ccomaintained things. Users should use the cco thing instead. There is no loss or change in functionality.

  • Discovery will now create cco instead of ccopulsed and ccomaintained things.
  • The ccopulsed and ccomaintained thing types are now defined with listed=false.
  • The thing descriptions are marked with "Deprecated".
  • Docs have been updates with the change.

Looking back, I should not have created separate cco, ccopulsed, and ccomaintained things. I did it based on some mistaken assumptions about discovery. So now is as good a time as any to clean this up. The deprecated things will continue to work for now, but I would like to remove them in or after the OH 3.0 release.

* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
@TravisBuddy
Copy link

Travis tests have failed

Hey @bobadair,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@bobadair bobadair requested a review from a team July 19, 2020 16:25
@bobadair bobadair added the enhancement An enhancement or new feature for an existing add-on label Jul 23, 2020
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 7e5d033 into openhab:2.5.x Jul 28, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 28, 2020
@bobadair bobadair deleted the lutroncco branch July 28, 2020 14:22
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
* Deprecates ccopulsed and ccomaintained things.
* Users should use the cco thing instead. There is no loss or change in functionality.

Signed-off-by: Bob Adair <bob.github@att.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants