[lgwebos] Thing actions still working after a bundle restart #8114
Conversation
Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
lgwebos_thingactionsrestart
branch
from
aca8e6f
to
4effec8
Compare
Travis tests have failedHey @lolodomo, |
|
Related to #8116 |
|
|
||
| public void launchBrowser(String url); | ||
|
|
||
| public List<Application> getApplications(); |
There was a problem hiding this comment.
I don't think the bugfix would work here. The proxy workaround would only work for methods that have parameters and return types that are loaded in a 3rd untouched classloader (e.g. parent or core). The Application class is loaded as part of the bundle classloader so the bug would still be present when LGWebOSActions attempts to use Application instances returned from getApplications().
One thing to note is that getApplications isn't annotated with @RuleAction which would mean the getApplications static method doesn't have a corresponding RuleAction. I'm not sure why this would be the case.
@sprehn can you give an explanation?
There was a problem hiding this comment.
Ok, even if we could still have a problem with getApplications, at least it will be ok for all other actions.
As we are on a temporary workaround, I propose to accept this limit and mention it with a comment in the code.
Is it ok for you ?
For the missing @RuleAction , good catch, I hope @sprehn is still available to answer this question.
There was a problem hiding this comment.
Comment added for getApplications
There was a problem hiding this comment.
Hi, this method's intend is to allow users to find out what the Ids of applications are. It is not designed to work with the new rule engine. I think it is now safe to remove it all together from the action, as the binding can now be queried for the same information via karaf console.
There was a problem hiding this comment.
Done, action removed.
There was a problem hiding this comment.
super, pls do me the favor and also delete the section in the readme file.
https://www.openhab.org/addons/bindings/lgwebos/#list-getapplications
There was a problem hiding this comment.
since this is merged already, see #8161
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests have failedHey @lolodomo, |
|
|
||
| public void launchBrowser(String url); | ||
|
|
||
| public List<Application> getApplications(); |
There was a problem hiding this comment.
Hi, this method's intend is to allow users to find out what the Ids of applications are. It is not designed to work with the new rule engine. I think it is now safe to remove it all together from the action, as the binding can now be queried for the same information via karaf console.
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests have failedHey @lolodomo, |
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: MPH80 <michael@hazelden.me>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
…#8114) * [lgwebos] Thing actions still working after a bundle restart * Action getApplications removed Related to openhab/openhab-core#1265 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Related to openhab/openhab-core#1265
Signed-off-by: Laurent Garnier lg.hc@free.fr