[netatmo] Make safe the execution of the refresh token job #8127
Conversation
Fix openhab#4270 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests were successfulHey @lolodomo, |
| @@ -168,6 +168,10 @@ private void scheduleTokenInitAndRefresh() { | |||
| return; | |||
| } | |||
| } | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
Try to minimize the scope of the catch to just the runtime exceptions since any checked exceptions added in the future changes might unintentionally get handled the same.
| } catch (Exception e) { | |
| } catch (RuntimeException e) { |
There was a problem hiding this comment.
After reading about RuntimeException vs Exception, I agree with you.
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Travis tests were successfulHey @lolodomo, |
|
@cpmeister @kaikreuzer @J-N-K @cweitkamp : is it possible please to have this PR merged before the release of 2.5.7 ? |
|
Can this be merged quickly or is it now already too late for the release 2.5.7 ? |
|
I‘ll make sure this is merged before 2.5.7. IMO the comment from @cpmeister is fully addressed but I would prefer to have his approval. 2.5.7 is expected next weekend. |
|
Ah ok, if we have still one week, I will stop pushing soo much ;) |
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job Signed-off-by: CSchlipp <christian@schlipp.de>
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job Signed-off-by: MPH80 <michael@hazelden.me>
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job Signed-off-by: Daan Meijer <daan@studioseptember.nl>
) Fixes openhab#4270 * [netatmo] Make safe the execution of the refresh token job
Fix #4270
Signed-off-by: Laurent Garnier lg.hc@free.fr