New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telegram] Added support for long polling #8180

Merged

Hilbrand merged 1 commit into openhab:2.5.x from EvilPingu:develop

Jul 29, 2020

Contributor

EvilPingu commented Jul 23, 2020 •

edited

Loading

This PL closes #7043

I added a new parameter for long polling. There is a new parameter with default value 25 seconds. The Telegram WebApp uses 25 seconds. Maximal value is 50 seconds. After this time the telegram api interups the connection.

Additional i fixed some warnings.

EvilPingu marked this pull request as ready for review

July 23, 2020 18:29

EvilPingu requested a review from ZzetT as a code owner

July 23, 2020 18:29

TravisBuddy commented Jul 23, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

EvilPingu changed the title ~~Develop~~ [telegram] Added support for long polling

TravisBuddy commented Jul 24, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

ZzetT suggested changes

View reviewed changes

bundles/org.openhab.binding.telegram/src/main/resources/ESH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved

bundles/org.openhab.binding.telegram/src/main/resources/ESH-INF/thing/thing-types.xml Show resolved Hide resolved

...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java Show resolved Hide resolved

TravisBuddy commented Jul 27, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

2 similar comments

TravisBuddy commented Jul 27, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy commented Jul 27, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

ZzetT approved these changes

View reviewed changes

ZzetT left a comment

review done

Hilbrand reviewed

View reviewed changes

bundles/org.openhab.binding.telegram/README.md Outdated Show resolved Hide resolved

TravisBuddy commented Jul 29, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

EvilPingu requested review from alexf2015, bobadair, clinique, cweitkamp, davidgraeff, gerrieg, gnlpfjh, J-N-K, lolodomo, mgeramb, ollie-dev, reyem, robnielsen, sprehn, ssalonen and a team as code owners

July 29, 2020 17:26


add long polling

f7d8587

Signed-off-by: Christian Kittel <ckittel@gmx.de>

Contributor Author

EvilPingu commented Jul 29, 2020

Sorry. I failed rebasing my branch. Now it's correct.

TravisBuddy commented Jul 29, 2020

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand removed request for davidgraeff, ssalonen, robnielsen, sprehn, clinique, cweitkamp, J-N-K, reyem, gerrieg, ollie-dev, lolodomo, gnlpfjh, alexf2015, mgeramb and bobadair

July 29, 2020 19:46

Hilbrand approved these changes

View reviewed changes

Member

Hilbrand left a comment

LGTM

Hilbrand merged commit 95a47fa into openhab:2.5.x

Hilbrand added this to the 2.5.8 milestone

MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

02b9553

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>
Signed-off-by: MPH80 <michael@hazelden.me>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

ed8569d

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

d646722

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

6aad687

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

2e749d2

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>

DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

f62c153

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

e74f374

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request


[telegram] Added support for long polling (openhab#8180)

4b8ca3f

Closes openhab#7043
Signed-off-by: Christian Kittel <ckittel@gmx.de>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment