Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] fix port leak - max datagram sockets reached #8189

Merged
merged 2 commits into from
Jul 26, 2020
Merged

[miio] fix port leak - max datagram sockets reached #8189

merged 2 commits into from
Jul 26, 2020

Conversation

marcelrv
Copy link
Contributor

[miio] fix port leak

Fix Max Datagram connections reached issue

Possibly also addressing #8091 as exception during closing would prevent thread closing

@marcelrv
[miio] fix port leak
84565de 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv
[miio] avoid re-assigning thread
d2e4e71 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Jul 24, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @marcelrv,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@marcelrv marcelrv requested a review from cpmeister July 24, 2020 21:30
@marcelrv marcelrv changed the title Miio max sockets [miio] fix port leak - max datagram sockets reached Jul 24, 2020
fwolter
fwolter approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 0b85d8a into openhab:2.5.x Jul 26, 2020
@fwolter fwolter added this to the 2.5.8 milestone Jul 26, 2020
@marcelrv marcelrv deleted the miio-max-sockets branch July 27, 2020 07:00
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@marcelrv @MPH80
[miio] fix port leak - max datagram sockets reached (openhab#8189)
5ca5aff 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] fix port leak - max datagram sockets reached (openhab#8189)
acaeecc 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] fix port leak - max datagram sockets reached (openhab#8189)
3df8789 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] fix port leak - max datagram sockets reached (openhab#8189)
acf687b 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] fix port leak - max datagram sockets reached (openhab#8189)
9eacb58 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@marcelrv @DaanMeijer
[miio] fix port leak - max datagram sockets reached (openhab#8189)
bf95d3f 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@marcelrv @markus7017
[miio] fix port leak - max datagram sockets reached (openhab#8189)
d0ad324 
Fix Max Datagram connections reached issue
Possibly also addressing openhab#8091 as exception during closing would prevent
thread closing

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv mentioned this pull request Oct 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@cpmeister cpmeister Awaiting requested review from cpmeister

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelrv @TravisBuddy @fwolter