Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tankerkoenig] Refactoring of Tankerkönig Binding #8221

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

cweitkamp
Copy link
Contributor

  • Removed dependency on org.apache.commons
  • Added nullness annotations
  • Moved model classes into dto folder
  • Minor improvements / SAT findings

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp requested a review from JueBag as a code owner July 29, 2020 12:27
@cweitkamp cweitkamp changed the title [tinarkoenig] Refactoring of Tankerkönig Binding [tankerkoenig] Refactoring of Tankerkönig Binding Jul 29, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@fwolter fwolter merged commit 58e249d into openhab:2.5.x Jul 29, 2020
@fwolter fwolter added this to the 2.5.8 milestone Jul 29, 2020
@cweitkamp cweitkamp deleted the feature-tankerkoenig-refactoring branch July 29, 2020 18:30
@JueBag
Copy link

JueBag commented Jul 29, 2020

Thanks for those changes.

MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: MPH80 <michael@hazelden.me>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants