Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homematic] Better support for rollershutters + several smaller fixes #8242

Merged
merged 10 commits into from
Aug 10, 2020
Merged

[homematic] Better support for rollershutters + several smaller fixes #8242

merged 10 commits into from
Aug 10, 2020

Conversation

MHerbst
Copy link
Contributor

@MHerbst MHerbst commented Aug 2, 2020

This PR contains solutions for a number of issues. Most of them have been successfully tested by several users.

Signed-off-by: Martin Herbst develop@mherbst.de

@MHerbst
Set bridge state to offline for duty cycle = -1
0e677d8 
Fixes #6360

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
Correct support of UP/DOWN for rollershutter devices
322950b 
Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.

Fixes #6145
Fixes #5042

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
Use correct type Contact for state channel of tilt sensor
80e4db9 
Fixes #5674

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
Support type Int64 for messages from Homegear
0bb5c6e 
Fixes #8081


Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
Correct max data point value of certain HmIP devices
08c2678 
Some data points of HmIP are returning 1.01d as max value instead of the
correct value of 1.0.

Fixes #6688

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
HM channel "Blind Transmitter" also indicates a rollershutter
c0ca422 
Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
Reduced log level for certain datapoints to avoid flooding the logs
c06428a 
HmIP devices introduced new channel configuration datapoints that can't
curently be detected automatically, but the CCU sometimes sends events
and the logs were flooded with warnings.

Fixes #5048


Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
CuxD interface apparently does not support the rssiInfo method
01a1fe0 
Fixes #6743

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
equals method call not necessary because of enum usage
6f01794 
Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst
HM method does not return any data if HmIP only is used
63b8109 
Fixes #5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
@MHerbst MHerbst requested a review from gerrieg as a code owner August 2, 2020 18:21
@TravisBuddy
Copy link

Travis tests have failed

Hey @MHerbst,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@TravisBuddy
Copy link

Travis tests were successful

Hey @MHerbst,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@MHerbst MHerbst changed the title [homematic] Several smaller fixes [homematic] Better support for rollershutters + several smaller fixes Aug 10, 2020
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Aug 10, 2020
@kaikreuzer kaikreuzer added this to the 2.5.8 milestone Aug 10, 2020
@kaikreuzer kaikreuzer merged commit e03d0a1 into openhab:2.5.x Aug 10, 2020
@kaikreuzer
Copy link
Member

Thanks @MHerbst for that many fixes and improvements! 👍

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@MHerbst @andrewfg
[homematic] Better support for rollershutters + several smaller fixes (…
ae98ffe 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@MHerbst @andrewfg
[homematic] Better support for rollershutters + several smaller fixes (…
b25b23e 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@MHerbst @andrewfg
[homematic] Better support for rollershutters + several smaller fixes (…
7c0612b 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@MHerbst @andrewfg
[homematic] Better support for rollershutters + several smaller fixes (…
eb82a20 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@MHerbst @DaanMeijer
[homematic] Better support for rollershutters + several smaller fixes (…
048c52c 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@MHerbst @CSchlipp
[homematic] Better support for rollershutters + several smaller fixes (…
70a5ce3 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@MHerbst @markus7017
[homematic] Better support for rollershutters + several smaller fixes (…
7841ca9 
…openhab#8242)

* Set bridge state to offline for duty cycle = -1
* Use correct type Contact for state channel of tilt sensor
* Support type Int64 for messages from Homegear
* Correct support of UP/DOWN for rollershutter devices - Important: UP command must send 1.0 to the device instead of the maximum
value returned by Homematic which is 1.01 and does not work.
* Correct max data point value of certain HmIP devices - Some data points of HmIP are returning 1.01d as max value instead of the correct value of 1.0.
* HM channel "Blind Transmitter" also indicates a rollershutter
* Reduced log level for certain datapoints to avoid flooding the logs - HmIP devices introduced new channel configuration datapoints that can't currently be detected automatically, but the CCU sometimes sends events and the logs were flooded with warnings.
* CuxD interface apparently does not support the rssiInfo method
* equals method call not necessary because of enum usage
* HM method does not return any data if HmIP only is used

Fixes openhab#6360
Fixes openhab#6145
Fixes openhab#5042
Fixes openhab#5674
Fixes openhab#8081
Fixes openhab#6688
Fixes openhab#5048
Fixes openhab#6743
Fixes openhab#5062

Signed-off-by: Martin Herbst <develop@mherbst.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@gerrieg gerrieg Awaiting requested review from gerrieg

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.
3 participants
@MHerbst @TravisBuddy @kaikreuzer