-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shelly] Add channels device#deviceName, relay#outputName + refactoring #8396
Conversation
trigger when binding was started; StringUtils replaced by native Java string operations Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Travis tests were successfulHey @markus7017, |
Signed-off-by: Markus Michels <markus7017@gmail.com>
Travis tests were successfulHey @markus7017, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As spotless is enabled in the 2.5.x
branch now, you need to fix those formatting errors with mvn spotless:apply
.
...inding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyDeviceProfile.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>
@fwolter How do we proceed? |
Travis tests have failedHey @markus7017, |
1 similar comment
Travis tests have failedHey @markus7017, |
modified with last commit Signed-off-by: Markus Michels <markus7017@gmail.com>
Travis tests were successfulHey @markus7017, |
definition for Dimmer/Dimmer2 corrected (the is no group status anymore) Signed-off-by: Markus Michels <markus7017@gmail.com>
@fwolter I changed channel channelName to outputName as dicussed From my side we are ready to merge |
bundles/org.openhab.binding.shelly/src/main/resources/ESH-INF/i18n/shelly_de.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Markus Michels <markus7017@gmail.com>
@fwolter change is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng (openhab#8396) Signed-off-by: Markus Michels <markus7017@gmail.com>
…ng (openhab#8396) Signed-off-by: Markus Michels <markus7017@gmail.com>
…ng (openhab#8396) Signed-off-by: Markus Michels <markus7017@gmail.com>
This PR adds 2 new channels
Those reflect the settings in the Shelly App and provide logical names for the device (all) and relay channels.
In addition Apache Comments (StringUtil+IOUtIOUtilsiul) was replaced by native code.