Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[max] add @notnullbydefault to eliminate warnings from commands classes #8427

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Sep 7, 2020

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

* add @notnullbydefault to classes in command
* replace org.apache.commons.lang.builder.ToStringBuilder with
StringBuilder (openhab#7722)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 6abf1ef into openhab:2.5.x Sep 8, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 8, 2020
@marcelrv marcelrv deleted the max-cleanup_commands branch September 8, 2020 21:21
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
…es (openhab#8427)

* add @notnullbydefault to classes in command
* replace org.apache.commons.lang.builder.ToStringBuilder with StringBuilder (openhab#7722)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
…es (openhab#8427)

* add @notnullbydefault to classes in command
* replace org.apache.commons.lang.builder.ToStringBuilder with StringBuilder (openhab#7722)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
…es (openhab#8427)

* add @notnullbydefault to classes in command
* replace org.apache.commons.lang.builder.ToStringBuilder with StringBuilder (openhab#7722)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants