Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsscripting] ES6+ Support #8441

Closed
wants to merge 2 commits into from
Closed

[jsscripting] ES6+ Support #8441

wants to merge 2 commits into from

Conversation

jpg0
Copy link
Contributor

@jpg0 jpg0 commented Sep 10, 2020

Parent PR to track all the changes required to get ES6+ support into OH. This will remain WIP until it's dependencies are merged. This supercedes #6399.

Remaining pieces currently implemented that need to go somewhere:

@TravisBuddy
Copy link

Travis tests were successful

Hey @jpg0,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@jpg0
Copy link
Contributor Author

jpg0 commented Sep 10, 2020

A question here for the maintainers - I am expecting that I should be targeting OH 3.x here. Should I be working against master? If so why is it so far behind 2.5.x?

@Hilbrand
Copy link
Member

Yes if you're targeting openHAB 3 you should work against master. It's not behind 2.5.x. It's just different. On the master only code compatible with 3.0 is present. All current development is done on 2.5.x and automigrated to 3.0 at the moment. Once 2.5.9 is released the 2.5.x branch will be migrated to 2.0 and merged back into the master and the master will become the default again.

@Hilbrand Hilbrand added the oh3 label Sep 10, 2020
@jpg0
Copy link
Contributor Author

jpg0 commented Sep 10, 2020

Thanks @Hilbrand. That makes perfect sense to me, however the message on master of "This branch is 81 commits ahead, 1009 commits behind 2.5.x." made me afraid that the automerging isn't happening and I'm in danger of colliding with changes on 2.5.x that are yet to land in master.

I'll assume that this isn't the case and target master.

@jpg0 jpg0 changed the base branch from 2.5.x to master September 10, 2020 06:27
Signed-off-by: Jonathan Gilbert <jpg@trillica.com>
@TravisBuddy
Copy link

Travis tests have failed

Hey @jpg0,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@kaikreuzer
Copy link
Member

@jpg0 All fine here - all you need to do to also make the build happy is to add your new project to the reactor pom.xml as well.

@jpg0 jpg0 mentioned this pull request Sep 12, 2020
Signed-off-by: Jonathan Gilbert <jpg@trillica.com>
@kaikreuzer kaikreuzer closed this Sep 20, 2020
@jpg0
Copy link
Contributor Author

jpg0 commented Sep 20, 2020

@kaikreuzer did you mean to close this?

@kaikreuzer
Copy link
Member

Nope, see (4) in #8512 😄 .

@jpg0 jpg0 mentioned this pull request Sep 21, 2020
@jpg0
Copy link
Contributor Author

jpg0 commented Sep 21, 2020

Reopened as #8516

@wborn wborn added new automation and removed oh3 labels Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants