Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[satel] Add support for event type 32 #8444

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

druciak
Copy link
Member

@druciak druciak commented Sep 10, 2020

This PR adds support for additional event log event type. Related community discussion is here: https://community.openhab.org/t/satel-binding-support-announcements-and-feature-requests/56135/209

Besides that there are some minor changes in the examples section od README file.

Signed-off-by: Krzysztof Goworek krzysztof.goworek@gmail.com

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
@druciak druciak added the enhancement An enhancement or new feature for an existing add-on label Sep 10, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @druciak,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 69e5b9d into openhab:2.5.x Sep 10, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 10, 2020
@druciak
Copy link
Member Author

druciak commented Sep 10, 2020

Thanks for very quick merge, @Hilbrand

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
)

Besides that there are some minor changes in the examples section of README file.

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
)

Besides that there are some minor changes in the examples section of README file.

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
)

Besides that there are some minor changes in the examples section of README file.

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants