Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix Eclipse .project, .classpath files #8450

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Sep 11, 2020

These changes were necessary to fix errors when opening these projects in Eclipse.

These changes were necessary to fix errors when opening these projects in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested review from andrewfg, pail23 and a team as code owners September 11, 2020 11:05
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Wdyt about removing these files with OH 3? Their generated with importing a maven project anyway.

@wborn
Copy link
Member Author

wborn commented Sep 11, 2020

I'd love to see them removed because it always results in modified files after updating projects.

There was #5670 for this, @kaikreuzer in #5670 (comment):

I can only be convinced that they should be removed if I am shown an (automatic) Eclipse IDE setup that doesn't work worse than before the change...

Since add-on projects are no longer automatically imported during the IDE setup (openhab/openhab-distro#1061) that may convince @kaikreuzer that the files can be removed. 😉

Removing them causes everyone having to reimport their Eclipse projects. So when all 2.5.x add-ons are migrated to the master branch, it might be a good time to also remove these Eclipse project files.

@J-N-K
Copy link
Member

J-N-K commented Sep 11, 2020

They are also useless when other IDEs are used.

@Hilbrand
Copy link
Member

People probably need to reinstall eclipse with Java 11 anyway. So another reason. I'm going to make an issue and put it on the project page.

@Hilbrand
Copy link
Member

Issue created #8451

@Hilbrand Hilbrand merged commit 8c001ed into openhab:2.5.x Sep 11, 2020
@Hilbrand Hilbrand added the infrastructure Build system and Karaf related issues and PRs label Sep 11, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 11, 2020
@wborn wborn deleted the eclipse-project-file-fixes branch September 11, 2020 13:08
@kaikreuzer
Copy link
Member

Since add-on projects are no longer automatically imported during the IDE setup (openhab/openhab-distro#1061) that may convince @kaikreuzer that the files can be removed.

Well, as all of you seem to be clear on it, I hardly stand a chance to argue against it as it seems.
Import as Maven project seems to work ok by now, so that seems indeed a standard way to use then.
Only downside is that we have different approaches for core+distro and add-ons then, because for the proper IDE setup, I hope we keep core+distro the way they are - unless someone manages to change the Oomph setup to smoothly import those projects as Maven projects.

@Hilbrand
Copy link
Member

I would not change core+distro either at the moment. Both already use a different strategy as they import all project during setup. Developing core already seems more advanced. Sometimes people setup eclipse for binding development and also check core and end up with a lot of errors. So there is room for improvement. I also updated the issue to add a not to update the documentation to use maven import for addon development.

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
These changes were necessary to fix errors when opening these projects in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
These changes were necessary to fix errors when opening these projects in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
These changes were necessary to fix errors when opening these projects in Eclipse.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants