[opensprinkler] fix hardcoded network prefix in discovery service #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
update fork
update fork
update fork
update fork
update fork
update fork
update fork
Update fork
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
requested review from
CrackerStealth and
FlorianSW
as code owners
Travis tests were successfulHey @mlobstein, |
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this in #7568 and it was suggested to make the prefix dynamic instead of just hard coding for /24 networks. If the user is not on a /24 network (such as 10.x.x.x), the discovery might fail to locate an active device. I am changing it here also to be consistent with all the other bindings that use this pattern of getting the list of all addresses in the subnet for discovery scans.