[tr064] Initial contribution #8523

J-N-K · 2020-09-21T17:00:28Z

This provides a replacement for the OH1 "fritzboxtr064" binding.

Replaces #6678

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

TravisBuddy · 2020-09-21T18:10:55Z

Travis tests have failed

Hey @J-N-K,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

cpmeister · 2020-09-24T17:53:22Z

...rg.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/SOAPConnector.java

+ * @return the SOAPMessage answer from the remote host
+ * @throws Tr064CommunicationException if an error occurs during the request
+ */
+ public synchronized SOAPMessage doSOAPRequest(SCPDServiceType service, String soapAction,


Why is this synchronized?

IIRC there was a problem when several requests are executed at the same time and return 401. It was not poissble to get the re-auth working in that case.

...enhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/SOAPValueConverter.java

...rg.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/SOAPConnector.java

bundles/org.openhab.binding.tr064/pom.xml

...openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064RootHandler.java

lionhe1966 · 2020-10-03T06:49:09Z

I am not sure if this is the right place to ask. Will the binding allow connection to more than one fritzbox? My use case would be presence detection on the fritzbox in my local network and on a VPN connected remote fritzbox.

J-N-K · 2020-10-03T07:08:41Z

@lionhe1966 yes

...ab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064DiscoveryService.java

J-N-K · 2020-10-03T17:35:08Z

Interesting. The build does not fail locally. And the error is wrong anyway, returning null is fully valid and results in an empty Optional.

wborn · 2020-10-03T17:52:53Z

You'd see this error if you are using a newer version of Eclipse or if you rebase on the current main branch.
Travis is now using an updated compiler (2 years newer) similar to that being used in current Eclipse versions (see #8636).

J-N-K · 2020-10-03T19:40:10Z

@wborn It‘s still wrong. Obviously the compiler update breaks valid code. It‘s very hard to create a work around. Maybe ist improves when we have external null annotations in place.

wborn · 2020-10-03T20:11:17Z

At least you only need to make one workaround instead of two because of the more similar compiler versions. ;-)
Doesn't adding @NonNullByDefault({}) or @Nullable fix it?

...nhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064HandlerFactory.java

....openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064SubHandler.java

...openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064RootHandler.java

...rg.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/SOAPConnector.java

jgantenberg · 2020-10-25T16:00:26Z

I changed from version 1 binding to the test version of the fritzboxtr064 binding. I managed to set it up I receive valid values for example from the WAN-sub-device. I set it up via paper ui and filled in proper values for the root device for hostname, user, password etc. Also for tam index and the number of days for incoming and outgoing calls.

Expected Behavior
the filled in hostname should be used for communication with the fritzbox.
I also expect additional things to be automatically created corresponding to the configuration settings, for example a ringing indicator or missed calls thing.

Current Behavior
The configuration for hostname is stored but the name fritz.box has to be resolvable. Otherwise the binding won't start complaining fritz.box can't be resolved.
In the section for the additional values none of the values is stored and I don't see additional things for incoming calls etc.

Possible Solution
Steps to Reproduce (for Bugs)
setup new root device
reopen configuration
search for things
Context
Your Environment
Version used: openHAB 2.5.9, org.openhab.binding.fritzboxtr064-2.5.6-SNAPSHOT.jar
Fritzbox 6591 cable, 7.13
ubuntu focal x86
OpenJDK Runtime Environment Zulu11.43+21-CA (build 11.0.9+11-LTS)

J-N-K · 2020-10-25T16:06:56Z

@jgantenberg I already responded in the community forum thread. Please set the binding to TRACE logging and show the log.

jgantenberg · 2020-10-25T16:32:49Z

@jgantenberg I already responded in the community forum thread. Please set the binding to TRACE logging and show the log.
openhab.log-1.txt
hope, there are no confidential informations inside

J-N-K · 2020-10-31T14:40:50Z

@jgantenberg This happens after you configured a different hostname than fritz.box?

J-N-K · 2020-10-31T14:43:42Z

@cpmeister I think I addressed most of your comments and commented on the remaining issues.

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

kaikreuzer

Some small final comments from me - rest is fine and imho good for being merged.

bundles/org.openhab.binding.tr064/src/main/feature/feature.xml

...enhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/SOAPValueConverter.java

...nhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064HandlerFactory.java

bundles/org.openhab.binding.tr064/README.md

...rg.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/SCPDUtil.java

...es/org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

J-N-K · 2020-10-31T21:01:31Z

Jenkins fails on the tado-library. I wonder what is wrong there.

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

kaikreuzer

Thanks!

jgantenberg · 2020-11-01T13:17:11Z

@jgantenberg This happens after you configured a different hostname than fritz.box?

yes, I have configured another hostname for my fritzbox, that is configured properly in DNS. I can fill in IP or hostname, the message that fritz.box cannot be resolved remained the same.

J-N-K · 2020-11-01T13:32:58Z

@jgantenberg That must be due to the old version you are using (I'm not sure if that was hard-coded in an earlier version). I checked that it works in the current version if I assign an IP address instead of a host-name. Please try again, when this has been merged (I guess that will happen in the next days).

jgantenberg · 2020-11-04T09:09:35Z

I have another question: is there also a ringing indicator channel as it was in the v1 binding? It was nice to have it to evaluate in rules, e.g. lowering volume of music or tv.
Thanks.

cweitkamp · 2020-11-17T12:12:26Z

@J-N-K Thanks for this great implementation. I am playing with the Phonebook Profile combined with the avmfritz Call Monitor. Do you already have an working example?

When adding the Profile via UI I am not able to see the configuration for it:

There is an Internal 500 with the following error message:

"{\"error\":{\"message\":\"stream has already been operated upon or closed\",\"http-code\":500,\"exception\":{\"class\":\"java.lang.IllegalStateException\",\"message\":\"stream has already been operated upon or closed\",\"localized-message\":\"stream has already been operated upon or closed\"}}}"

I saw you implemented a ConfigOptionProvider for the parameter phonebook using a lot of streaming stuff I assume this is somehow related. Any ideas? Disabling / Removing the ConfigOptionProvider at least eliminates the Internal 500 and lets me see the Profile configuration in the UI.

cweitkamp · 2020-11-17T13:08:30Z

I found basic solution for it in #9054.

* Initial contribution

* Initial contribution Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

J-N-K requested a review from a team as a code owner September 21, 2020 17:00

Hilbrand added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Sep 22, 2020

kaikreuzer mentioned this pull request Sep 25, 2020

[avmfritz] Support for missing important features of the TR064 binding #8578

Closed

J-N-K self-assigned this Sep 25, 2020

Hilbrand mentioned this pull request Sep 25, 2020

openHAB 1 addon compatibility overview with openHAB 3 #6179

Closed

J-N-K removed their assignment Sep 27, 2020

cpmeister requested changes Oct 2, 2020

View reviewed changes

J-N-K force-pushed the tr064 branch from 4a04e7f to 28368f9 Compare October 3, 2020 14:55

cpmeister requested changes Oct 3, 2020

View reviewed changes

...ab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/Tr064DiscoveryService.java Outdated Show resolved Hide resolved

cpmeister requested changes Oct 3, 2020

View reviewed changes

J-N-K force-pushed the tr064 branch from 21a2e41 to 89f8a64 Compare October 6, 2020 14:42

kaikreuzer mentioned this pull request Oct 25, 2020

[TR-064 Binding] configuration for fritzbox-root device not stored properly #8864

Closed

J-N-K force-pushed the tr064 branch from 96d17ba to 554708d Compare October 31, 2020 09:32

Initial contribution

9720046

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

J-N-K force-pushed the tr064 branch from 270937d to 9720046 Compare October 31, 2020 16:46

kaikreuzer requested changes Oct 31, 2020

View reviewed changes

cpmeister reviewed Oct 31, 2020

View reviewed changes

...rg.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/SCPDUtil.java Outdated Show resolved Hide resolved

cpmeister requested changes Oct 31, 2020

View reviewed changes

...es/org.openhab.binding.tr064/src/main/java/org/openhab/binding/tr064/internal/util/Util.java Outdated Show resolved Hide resolved

J-N-K added 2 commits October 31, 2020 21:08

address review comments

67bcc24

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

address review comments

f60b025

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

address last review comments

5180bd3

Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

kaikreuzer approved these changes Nov 1, 2020

View reviewed changes

cpmeister approved these changes Nov 3, 2020

View reviewed changes

cpmeister merged commit a3d33fa into openhab:main Nov 3, 2020

cpmeister added this to the 3.0.0.M3 milestone Nov 3, 2020

J-N-K deleted the tr064 branch November 4, 2020 14:11

nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021

[tr064] Initial contribution (openhab#8523)

bedec88

* Initial contribution

boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021

[tr064] Initial contribution (openhab#8523)

2428b51

* Initial contribution Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[tr064] Initial contribution (openhab#8523)

201b3ff

* Initial contribution Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tr064] Initial contribution #8523

[tr064] Initial contribution #8523

J-N-K commented Sep 21, 2020

TravisBuddy commented Sep 21, 2020 •

edited

Loading

cpmeister Sep 24, 2020

J-N-K Oct 3, 2020

lionhe1966 commented Oct 3, 2020

J-N-K commented Oct 3, 2020

J-N-K commented Oct 3, 2020 •

edited

Loading

wborn commented Oct 3, 2020

J-N-K commented Oct 3, 2020

wborn commented Oct 3, 2020

jgantenberg commented Oct 25, 2020

J-N-K commented Oct 25, 2020

jgantenberg commented Oct 25, 2020 •

edited

Loading

J-N-K commented Oct 31, 2020

J-N-K commented Oct 31, 2020

kaikreuzer left a comment

J-N-K commented Oct 31, 2020

kaikreuzer left a comment

jgantenberg commented Nov 1, 2020

J-N-K commented Nov 1, 2020

jgantenberg commented Nov 4, 2020

cweitkamp commented Nov 17, 2020

cweitkamp commented Nov 17, 2020

[tr064] Initial contribution #8523

[tr064] Initial contribution #8523

Conversation

J-N-K commented Sep 21, 2020

TravisBuddy commented Sep 21, 2020 • edited Loading

Travis tests have failed

cpmeister Sep 24, 2020

Choose a reason for hiding this comment

J-N-K Oct 3, 2020

Choose a reason for hiding this comment

lionhe1966 commented Oct 3, 2020

J-N-K commented Oct 3, 2020

J-N-K commented Oct 3, 2020 • edited Loading

wborn commented Oct 3, 2020

J-N-K commented Oct 3, 2020

wborn commented Oct 3, 2020

jgantenberg commented Oct 25, 2020

J-N-K commented Oct 25, 2020

jgantenberg commented Oct 25, 2020 • edited Loading

J-N-K commented Oct 31, 2020

J-N-K commented Oct 31, 2020

kaikreuzer left a comment

Choose a reason for hiding this comment

J-N-K commented Oct 31, 2020

kaikreuzer left a comment

Choose a reason for hiding this comment

jgantenberg commented Nov 1, 2020

J-N-K commented Nov 1, 2020

jgantenberg commented Nov 4, 2020

cweitkamp commented Nov 17, 2020

cweitkamp commented Nov 17, 2020

TravisBuddy commented Sep 21, 2020 •

edited

Loading

J-N-K commented Oct 3, 2020 •

edited

Loading

jgantenberg commented Oct 25, 2020 •

edited

Loading