[warmup] Initial contribution #8562

jamesmelville · 2020-09-23T20:21:52Z

This binding integrates the Warmup 4iE Thermostat https://www.warmup.co.uk/thermostats/smart/4ie-underfloor-heating, via the API at https://my.warmup.com/.

I logged an issue for this at #7996. This PR was initially logged against 2.5.x in this PR #7998. All the comments in the PR have been addressed in this new PR for version 3.0.

Per the readme, it currently supports a Bridge to the API, holding the API credentials, and Rooms, which report current temperature and setpoint, and allow setting of an override of the setpoint for a specified duration.

I have tested this successfully on my own installation.

Resolves #7996

TravisBuddy · 2020-09-23T20:26:45Z

Travis tests were successful

Hey @jamesmelville,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

bundles/org.openhab.binding.warmup/.classpath

bundles/org.openhab.binding.warmup/.project

bundles/org.openhab.binding.warmup/README.md

...rmup/src/main/java/org/openhab/binding/warmup/internal/handler/MyWarmupConfigurationDTO.java

...g.warmup/src/main/java/org/openhab/binding/warmup/internal/handler/RoomConfigurationDTO.java

...ab.binding.warmup/src/main/java/org/openhab/binding/warmup/internal/handler/RoomHandler.java

bundles/org.openhab.binding.warmup/src/main/resources/OH-INF/binding/binding.xml

bundles/org.openhab.binding.warmup/src/main/resources/OH-INF/thing/thing-types.xml

jamesmelville · 2020-12-01T21:13:44Z

Hi @fwolter thank you for your review - I've updated everything as requested except for the one conversation which remains open above. Alongside that I think I've simplified the error handling logic and removed some code which was stopping polling if an internet connection became unavailable, sorry if this adds to your work reviewing but I thought it was preferable. CI build hasn't completed but I'll keep an eye out for any issues raised. Also not sure how I added wborn as a code owner 🤷.

fwolter

The file bundles/org.openhab.automation.groovyscripting/userdata/persist.mqtt shouldn't be part of your PR.

What open point do you refer to?

bundles/org.openhab.binding.warmup/README.md

...binding.warmup/src/main/java/org/openhab/binding/warmup/internal/WarmupBindingConstants.java

...rmup/src/main/java/org/openhab/binding/warmup/internal/discovery/WarmupDiscoveryService.java

...ab.binding.warmup/src/main/java/org/openhab/binding/warmup/internal/handler/RoomHandler.java

jamesmelville · 2020-12-04T21:51:32Z

The file bundles/org.openhab.automation.groovyscripting/userdata/persist.mqtt shouldn't be part of your PR.

Sorry - I thought I'd already removed that but it's in my next push

What open point do you refer to?

The duplicated serialNumber, which is now removed, so the point is no longer open.

fwolter

You need to replace SmartHomeUnits by Units to make the code compile.

bundles/org.openhab.binding.warmup/src/main/resources/OH-INF/binding/binding.xml

...warmup/src/main/java/org/openhab/binding/warmup/internal/handler/MyWarmupAccountHandler.java

fwolter

LGTM

...warmup/src/main/java/org/openhab/binding/warmup/internal/handler/MyWarmupAccountHandler.java

...ab.binding.warmup/src/main/java/org/openhab/binding/warmup/internal/handler/RoomHandler.java

...ing.warmup/src/main/java/org/openhab/binding/warmup/internal/handler/WarmupThingHandler.java

cpmeister · 2021-01-14T02:34:25Z

Other than those few changes it looks good to me.

Hilbrand

There are some last open review comments. And since we're already into th enew year, new release some basic must be updated. Are you able to finish the binding so it can be merged?

bundles/org.openhab.binding.warmup/pom.xml

...binding.warmup/src/main/java/org/openhab/binding/warmup/internal/WarmupBindingConstants.java

fwolter · 2021-05-01T12:27:44Z

@jamesmelville can you fix the minor code review findings? Then we could merge this before OH 3.1 is released.

Signed-off-by: James Melville <jamesmelville@gmail.com>

jamesmelville · 2021-05-10T21:33:20Z

Hi @cpmeister @fwolter @Hilbrand - sorry for all the delays, life's been happening I guess! Anyway I think I've resolved all the review comments and got everything updated, not sure if I've done it in time for 3.1 but let me know!

fwolter

Thanks for addressing the remaining review comments!

LGTM

Your binding will make it into OH 3.1!

fwolter · 2021-05-13T14:00:53Z

Now, you could add your binding's logo to the openHAB website. See https://deploy-preview-1540--openhab-docs-preview.netlify.app/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

Signed-off-by: James Melville <jamesmelville@gmail.com>

jamesmelville requested a review from a team as a code owner September 23, 2020 20:21

jamesmelville mentioned this pull request Sep 23, 2020

[warmup] Add Support for Warmup 4iE Device [WIP] #7998

Closed

cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 24, 2020

fwolter self-assigned this Oct 4, 2020

fwolter requested changes Oct 4, 2020

View reviewed changes

fwolter added the awaiting feedback Awaiting feedback from the pull request author label Nov 1, 2020

jamesmelville force-pushed the warmup3 branch from 7163bf7 to d82e29f Compare December 1, 2020 20:03

jamesmelville requested a review from wborn as a code owner December 1, 2020 20:03

jamesmelville requested a review from fwolter December 2, 2020 22:11

fwolter removed the awaiting feedback Awaiting feedback from the pull request author label Dec 4, 2020

fwolter requested changes Dec 4, 2020

View reviewed changes

jamesmelville requested a review from fwolter December 8, 2020 20:19

fwolter requested changes Dec 13, 2020

View reviewed changes

bundles/org.openhab.binding.warmup/src/main/resources/OH-INF/binding/binding.xml Outdated Show resolved Hide resolved

...warmup/src/main/java/org/openhab/binding/warmup/internal/handler/MyWarmupAccountHandler.java Outdated Show resolved Hide resolved

jamesmelville requested a review from fwolter December 16, 2020 22:44

fwolter requested changes Dec 18, 2020

View reviewed changes

...warmup/src/main/java/org/openhab/binding/warmup/internal/handler/MyWarmupAccountHandler.java Outdated Show resolved Hide resolved

fwolter approved these changes Dec 18, 2020

View reviewed changes

fwolter added the cre Coordinated Review Effort label Dec 18, 2020

fwolter removed their assignment Dec 18, 2020

fwolter requested a review from a team December 26, 2020 09:34

cpmeister requested changes Jan 14, 2021

View reviewed changes

wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 22, 2021

Hilbrand reviewed Feb 4, 2021

View reviewed changes

bundles/org.openhab.binding.warmup/pom.xml Outdated Show resolved Hide resolved

...binding.warmup/src/main/java/org/openhab/binding/warmup/internal/WarmupBindingConstants.java Outdated Show resolved Hide resolved

fwolter added the awaiting feedback Awaiting feedback from the pull request author label Apr 10, 2021

[warmup] Initial Contribution for OpenHAB 3.0

8716184

Signed-off-by: James Melville <jamesmelville@gmail.com>

jamesmelville added 15 commits May 10, 2021 21:18

Mark Thermostat device as offline if not recently polled

7c89fad

Signed-off-by: James Melville <jamesmelville@gmail.com>

Don't cancel refresh on failure.

3072aae

Signed-off-by: James Melville <jamesmelville@gmail.com>

Review updates

38f90d2

Signed-off-by: James Melville <jamesmelville@gmail.com>

Updates from review comments

2376bb0

Signed-off-by: James Melville <jamesmelville@gmail.com>

Remove extraneous property

26af9b2

Signed-off-by: James Melville <jamesmelville@gmail.com>

Remove unwanted file, update readme, tweak set initialisation

f234b43

Signed-off-by: James Melville <jamesmelville@gmail.com>

Remove stack trace logging

c3db26c

Signed-off-by: James Melville <jamesmelville@gmail.com>

Remove extraneous code

e7d4b6a

Signed-off-by: James Melville <jamesmelville@gmail.com>

missing crlf in readme

3c3facf

Signed-off-by: James Melville <jamesmelville@gmail.com>

Remove Binding Author, Rename Units class

4714037

Signed-off-by: James Melville <jamesmelville@gmail.com>

Rejig error handling

371c4d2

Signed-off-by: James Melville <jamesmelville@gmail.com>

Remove pointless logging

4f656e6

Signed-off-by: James Melville <jamesmelville@gmail.com>

Update POM & License headers

adeb940

Signed-off-by: James Melville <jamesmelville@gmail.com>

Review Comment tweaks

eb8f9f8

Signed-off-by: James Melville <jamesmelville@gmail.com>

Access bridge handler on demand

0e544f0

Signed-off-by: James Melville <jamesmelville@gmail.com>

jamesmelville force-pushed the warmup3 branch from 1774251 to 0e544f0 Compare May 10, 2021 21:30

jamesmelville requested review from cpmeister and Hilbrand May 10, 2021 21:31

fwolter approved these changes May 13, 2021

View reviewed changes

fwolter changed the title ~~[warmup] Add Support for Warmup 4iE Device~~ [warmup] Initial contribution May 13, 2021

fwolter merged commit db05079 into openhab:main May 13, 2021

fwolter added this to the 3.1 milestone May 13, 2021

fwolter removed awaiting feedback Awaiting feedback from the pull request author cre Coordinated Review Effort labels May 13, 2021

computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021

[warmup] Initial contribution (openhab#8562)

9712559

Signed-off-by: James Melville <jamesmelville@gmail.com>

frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021

[warmup] Initial contribution (openhab#8562)

e2cf487

Signed-off-by: James Melville <jamesmelville@gmail.com>

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021

[warmup] Initial contribution (openhab#8562)

f8928b9

Signed-off-by: James Melville <jamesmelville@gmail.com>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[warmup] Initial contribution (openhab#8562)

d04717e

Signed-off-by: James Melville <jamesmelville@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[warmup] Initial contribution #8562

[warmup] Initial contribution #8562

jamesmelville commented Sep 23, 2020 •

edited by jlaur

Loading

TravisBuddy commented Sep 23, 2020

jamesmelville commented Dec 1, 2020

fwolter left a comment

jamesmelville commented Dec 4, 2020 •

edited

Loading

fwolter left a comment

fwolter left a comment

cpmeister commented Jan 14, 2021

Hilbrand left a comment

fwolter commented May 1, 2021

jamesmelville commented May 10, 2021

fwolter left a comment

fwolter commented May 13, 2021

[warmup] Initial contribution #8562

[warmup] Initial contribution #8562

Conversation

jamesmelville commented Sep 23, 2020 • edited by jlaur Loading

TravisBuddy commented Sep 23, 2020

Travis tests were successful

jamesmelville commented Dec 1, 2020

fwolter left a comment

Choose a reason for hiding this comment

jamesmelville commented Dec 4, 2020 • edited Loading

fwolter left a comment

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

cpmeister commented Jan 14, 2021

Hilbrand left a comment

Choose a reason for hiding this comment

fwolter commented May 1, 2021

jamesmelville commented May 10, 2021

fwolter left a comment

Choose a reason for hiding this comment

fwolter commented May 13, 2021

jamesmelville commented Sep 23, 2020 •

edited by jlaur

Loading

jamesmelville commented Dec 4, 2020 •

edited

Loading