[BMW ConnectedDrive] initial contribution #8576

weymann · 2020-09-24T22:12:45Z

Binding to connect BMW Vehicles via ConnectedDrive with openHAB.
It's supporting all types of Vehicles:

Conventional Fuel Vehicle
Plugin-Hybrid Electrical Vehicle
Battery Electric Vehicle with Range Extender
Battery Electric Vehicle

Concept is based on the project Bimmer Connected.
Also a manual installation based on python was already available for openHAB.

Test Bundle, Full Example and Enhancements described in Readme.md are available here

TravisBuddy · 2020-09-24T22:19:17Z

Travis tests were successful

Hey @weymann,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

fwolter

I reviewed the readme so far. Here is my feedback.

bundles/org.openhab.binding.bmwconnecteddrive/.classpath

bundles/org.openhab.binding.bmwconnecteddrive/.project

bundles/org.openhab.binding.bmwconnecteddrive/README.md

cpmeister

I wasn't able to finish reviewing it, so these are the things I found after my first pass.

...ve/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/ConnectedDriveConstants.java

...src/main/java/org/openhab/binding/bmwconnecteddrive/internal/discovery/VehicleDiscovery.java

...ecteddrive/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/dto/Destination.java

...e/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/dto/status/VehicleStatus.java

...rive/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/utils/BimmerConstants.java

...ecteddrive/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/utils/Constants.java

...ecteddrive/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/utils/Converter.java

...nhab.binding.bmwconnecteddrive/src/main/resources/OH-INF/thing/destination-channel-types.xml

...openhab.binding.bmwconnecteddrive/src/main/resources/OH-INF/thing/bridge-connected-drive.xml

bundles/org.openhab.binding.bmwconnecteddrive/README.md

kennethwhymns · 2020-12-01T12:05:50Z

I get a unauthorized error code if i try to connect using north america region

@kaikreuzer

Source is @kaikreuzer openhab/openhab-addons#8576 (comment) Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

@kaikreuzer

Source is @kaikreuzer openhab/openhab-addons#8576 (comment) Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

weymann · 2020-12-27T01:29:16Z

I get a unauthorized error code if i try to connect using north america region

@kennethwhymns
Yes, same problem was reported in the forum. Somehow the auth method was changed again in November and I fixed it some days ago. Few hours later I got the success confirmation from the US member who reported the bug. Bugfix is applied now for OH3 binding version.

bundles/org.openhab.binding.bmwconnecteddrive/.gitignore

bundles/org.openhab.binding.bmwconnecteddrive/README.md

...src/main/java/org/openhab/binding/bmwconnecteddrive/internal/discovery/VehicleDiscovery.java

...java/org/openhab/binding/bmwconnecteddrive/internal/handler/ConnectedDriveBridgeHandler.java

...rc/main/java/org/openhab/binding/bmwconnecteddrive/internal/handler/ConnectedDriveProxy.java

...rive/src/main/java/org/openhab/binding/bmwconnecteddrive/internal/utils/ImageProperties.java

.../main/java/org/openhab/binding/bmwconnecteddrive/internal/handler/VehicleChannelHandler.java

ntruchsess · 2021-02-16T10:08:37Z

I fixed most of the outstanding review-comments in new PR #10170

fwolter · 2021-03-03T16:58:47Z

Please raise your hand when you finished incorporating @cpmeister's findings. I will continue with the review, then.

ntruchsess · 2021-03-03T18:04:01Z

Please raise your hand when you finished incorporating @cpmeister's findings. I will continue with the review, then.

If you refer to my changes fixing @cpmeisters findings - they are all included in weymann#1 to @weymann s repository. Unfortunately he seems to have not enough time to review or merge, he didn't respond to my latest emails either. Feel free to check out my changes if you like. I'm willing to continue to work on this in case my contribution is appreciated. If not, I'm not bothered about it - it's open source, anybody might pick it up

ntruchsess

please remove obsolete catches of JsonSyntaxException

...va/org/openhab/binding/bmwconnecteddrive/internal/dto/compat/VehicleAttributesContainer.java

...rc/main/java/org/openhab/binding/bmwconnecteddrive/internal/handler/ConnectedDriveProxy.java

.../main/java/org/openhab/binding/bmwconnecteddrive/internal/handler/VehicleChannelHandler.java

weymann · 2021-03-07T20:07:58Z

Changes & fixes from @ntruchsess are in, review findings from @cpmeister are resolved, CI build is running successful again. Thanks to all we've a clean state again.

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

editable DateTimeType-channels, removal of minute and hour-channels

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

…ules rules for editing datetimes in sitemap

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

@kaikreuzer

rename actions-scope as requested by @kaikreuzer

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

descriptions in readme were swapped

openhab-bot · 2021-04-26T10:38:45Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/bmw-connecteddrive-binding/105124/1

bundles/org.openhab.binding.bmwconnecteddrive/README.md

bundles/org.openhab.binding.bmwconnecteddrive/src/main/resources/OH-INF/binding/binding.xml

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

fwolter

LGTM

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

weymann requested a review from a team as a code owner September 24, 2020 22:12

cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label Sep 25, 2020

kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 25, 2020

fwolter self-assigned this Oct 7, 2020

fwolter requested changes Oct 7, 2020

View reviewed changes

cpmeister requested changes Nov 21, 2020

View reviewed changes

kaikreuzer reviewed Nov 24, 2020

View reviewed changes

bundles/org.openhab.binding.bmwconnecteddrive/README.md Outdated Show resolved Hide resolved

fwolter added a commit to fwolter/openhab-docs that referenced this pull request Dec 6, 2020

Add max length for labels

234eb64

Source is @kaikreuzer openhab/openhab-addons#8576 (comment) Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

fwolter mentioned this pull request Dec 6, 2020

Add max length for labels openhab/openhab-docs#1299

Merged

Confectrician pushed a commit to openhab/openhab-docs that referenced this pull request Dec 10, 2020

Add max length for labels (#1299)

0cd3f91

Source is @kaikreuzer openhab/openhab-addons#8576 (comment) Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

weymann requested review from cpmeister and fwolter December 28, 2020 12:11

fwolter reviewed Dec 29, 2020

View reviewed changes

fwolter reviewed Dec 31, 2020

View reviewed changes

bundles/org.openhab.binding.bmwconnecteddrive/README.md Outdated Show resolved Hide resolved

wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 22, 2021

Hilbrand requested a review from fwolter January 25, 2021 07:45

cpmeister requested changes Feb 7, 2021

View reviewed changes

cpmeister self-assigned this Feb 9, 2021

ntruchsess mentioned this pull request Feb 16, 2021

[BMW ConnectedDrive] initial contribution #10170

Closed

ntruchsess requested changes Mar 6, 2021

View reviewed changes

weymann requested a review from cpmeister March 7, 2021 19:53

weymann and others added 15 commits March 29, 2021 03:49

add state tags to channels

03f4787

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

writable datetime channels for charge profile

59865cf

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

editable DateTimeType-channels, removal of minute and hour-channels

64813ea

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

channel-type-definitions & documentation-update

b53dd5f

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

Merge pull request #13 from ntruchsess/bmw-connected-drive-datetime

0801bea

editable DateTimeType-channels, removal of minute and hour-channels

rules for editing datetimes in sitemap

c368dc0

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

Merge pull request #14 from ntruchsess/bmw-connected-drive-datetime-r…

094538b

…ules rules for editing datetimes in sitemap

bugfix: set legacy mode only one time

420dae3

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

add missing translation

1156d89

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

rename actions-scope as requested by @kaikreuzer

5876481

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

adjust README to renames of actions

f2a23ec

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

Merge pull request #15 from ntruchsess/bmw-connected-drive-renameactions

c45fde8

rename actions-scope as requested by @kaikreuzer

correct Actions section in readme

afd5b16

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

descriptions were swapped

db78bab

Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

Merge pull request #16 from ntruchsess/bmw-connected-drive-readme

dd50d7e

descriptions in readme were swapped

weymann requested a review from fwolter April 12, 2021 08:35

weymann mentioned this pull request Apr 12, 2021

Multiple Actions per Binding/Thing #10510

Closed

fwolter requested changes Apr 29, 2021

View reviewed changes

bundles/org.openhab.binding.bmwconnecteddrive/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.bmwconnecteddrive/src/main/resources/OH-INF/binding/binding.xml Outdated Show resolved Hide resolved

remove logo and author from documentation

ac539e8

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>

fwolter approved these changes May 1, 2021

View reviewed changes

fwolter merged commit e69a65d into openhab:main May 1, 2021

fwolter added this to the 3.1 milestone May 1, 2021

weymann mentioned this pull request May 3, 2021

[bmwconnecteddrive] logo for upcoming new binding openhab/openhab-docs#1565

Merged

J-N-K mentioned this pull request Jun 20, 2021

[tr064] add action to create FritzBox backups smarthomej/addons#135

Merged

3 tasks

thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021

[BMW ConnectedDrive] initial contribution (openhab#8576)

dadbbdd

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[BMW ConnectedDrive] initial contribution (openhab#8576)

ecc018c

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com> Signed-off-by: Norbert Truchsess <norbert.truchsess@t-online.de>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BMW ConnectedDrive] initial contribution #8576

[BMW ConnectedDrive] initial contribution #8576

weymann commented Sep 24, 2020

TravisBuddy commented Sep 24, 2020 •

edited

Loading

fwolter left a comment

cpmeister left a comment

kennethwhymns commented Dec 1, 2020

weymann commented Dec 27, 2020

ntruchsess commented Feb 16, 2021

fwolter commented Mar 3, 2021

ntruchsess commented Mar 3, 2021

ntruchsess left a comment

weymann commented Mar 7, 2021

openhab-bot commented Apr 26, 2021

fwolter left a comment

[BMW ConnectedDrive] initial contribution #8576

[BMW ConnectedDrive] initial contribution #8576

Conversation

weymann commented Sep 24, 2020

TravisBuddy commented Sep 24, 2020 • edited Loading

Travis tests were successful

fwolter left a comment

Choose a reason for hiding this comment

cpmeister left a comment

Choose a reason for hiding this comment

kennethwhymns commented Dec 1, 2020

weymann commented Dec 27, 2020

ntruchsess commented Feb 16, 2021

fwolter commented Mar 3, 2021

ntruchsess commented Mar 3, 2021

ntruchsess left a comment

Choose a reason for hiding this comment

weymann commented Mar 7, 2021

openhab-bot commented Apr 26, 2021

fwolter left a comment

Choose a reason for hiding this comment

TravisBuddy commented Sep 24, 2020 •

edited

Loading