[dbquery] Initial contribution #8780

lujop · 2020-10-17T17:15:49Z

DBQuery Initial contribution

Initial contribution for a new addon that allows defining Things to execute native database queries.

This initial version provides support for InfluxDB 2.0 that is finished and usable.
In a future version in will I start to work after this, it will be submitted support for JDBC databases that currently OH support as persistence services.

A complete description of capabilities and usage of the addon is provided in it's README.

I created a new thread announcing the submission of this addon and for further discussion about it:
https://community.openhab.org/t/new-dbquery-addon-submitted/106640

The initial need for this addon was mainly discussed here:
https://community.openhab.org/t/influxdb-query-addon-proposal/95400/14

Here is another related issue that if sometime is implemented it will allow another DB implementation that uses an existing defined OH persistence service:
openhab/openhab-core#1512

TravisBuddy · 2020-10-17T18:03:57Z

Hey @lujop,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4c891b70-160a-11eb-94fa-edf6748ec8ed

Intial work history lost due to the repository shrunk done at c53e4ae (intially started from old unshrunked repo) Signed-off-by: Joan Pujol <joanpujol@gmail.com>

If database can be connected at bridge initialization schedule retry attempts. Prevent query execution scheduling if bridge isn't online Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Implement actions to execute query and get last query result Correctly serialize as JSON non scalar results to result channels Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

This reverts commit 21c0995. Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Skinah · 2021-02-25T08:25:47Z

Fails to build due to not being 3.1.0-SNAPSHOT

[FATAL] Non-resolvable parent POM for org.openhab.addons.bundles:org.openhab.binding.dbquery:[unknown-version]: Could not find artifact org.openhab.addons.bundles:org.openhab.addons.reactor.bundles:pom:3.0.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 7, column 11

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

lujop · 2021-09-24T19:59:53Z

@fwolter @Skinah I've just summited another commit with your review changes, if I didn't forget something, I think that's all done.

@fwolter

Done as suggested by @fwolter in openhab/openhab-addons#8780

Skinah · 2021-09-30T05:44:36Z

There are a few comments not addressed yet like putting each sentence on its own line in the readme. Take care of them and lets get this to compile with a green tick, just triggered a rebuild in case it was the build systems fault it failed.

Co-authored-by: Matthew Skinner <matt@pcmus.com>

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

lujop · 2021-09-30T21:12:15Z

There are a few comments not addressed yet like putting each sentence on its own line in the readme. Take care of them and lets get this to compile with a green tick, just triggered a rebuild in case it was the build systems fault it failed.

Done, I think that now it's all addressed.
About the addon compilation seems to build correctly in local. And in Jenkins the error I think that is prior to addon compilation, isn't it?

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Skinah · 2021-10-01T02:41:53Z

Can you run a mvn clean install from the root folder NOT from inside org.openhab.binding.dbquery/ folder? the latter folder does not check how it compiles as a whole project but is quicker to compile, so do it from the root folder and let it run. Then you will see what is failing. Also check what is in the code analysis report that is found in your target folder.

lujop · 2021-10-01T19:44:17Z

Can you run a mvn clean install from the root folder NOT from inside org.openhab.binding.dbquery/ folder? the latter folder does not check how it compiles as a whole project but is quicker to compile, so do it from the root folder and let it run. Then you will see what is failing. Also check what is in the code analysis report that is found in your target folder.

@Skinah Now seems to be ok, and I already checked the code analysis report and all seems ok to me

bundles/org.openhab.binding.dbquery/pom.xml

Skinah · 2021-10-02T06:51:28Z

I can't assist any further as the binding looks good to my noob eyes. Once @fwolter is happy I'm sure it will be good to merge as the build is showing as successful.

Skinah

LGTM

Just waiting on the open topics raised by @fwolter to be resolved.

fwolter

I don't see any open points. LGTM

fwolter · 2021-10-17T12:55:53Z

I just noticed, that the NOTICE file is missing. Can you please file another PR adding it?

lujop · 2021-10-17T20:49:03Z

Thank you @fwolter and @Skinah for your time reviewing the addon.

About the NOTICE, I will do the PR in the next days, also I will try to submit soon the JDBC part that it's quite ready and I'm already using in my installation

* Initial commit Intial work history lost due to the repository shrunk done at c53e4ae (intially started from old unshrunked repo) Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement reconnect attempts If database can be connected at bridge initialization schedule retry attempts. Prevent query execution scheduling if bridge isn't online Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Minor documentation changes and fix trigger channel name Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix NPE bug initializing ThingActions Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement query actions and another fixes Implement actions to execute query and get last query result Correctly serialize as JSON non scalar results to result channels Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parameters and correct channel Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting and forgot part on previous commit Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Improve documentation Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add javadoc comment and license to all classes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code cleanup Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Untrack unused i18n file Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix log level for query actions trace information Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add dbquery addon to bundles pom Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Temporary remove mqtt bindings that make travis build to fail Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Revert "Temporary remove mqtt bindings that make travis build to fail" This reverts commit 21c0995. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code clean up from static analysis Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update code to be compatible with 3.1.0 Update dependencies version Update Copyright Other minor changes for new static analysis validations. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Requested PR changes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/JDBCBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/DatabaseBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Apply suggestions from code review Co-authored-by: Matthew Skinner <matt@pcmus.com> * Suggestions from code review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parent version Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/jdbc-bridge.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Changes asked in PR review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * README documentation imporovements Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix format issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com>

* Initial commit Intial work history lost due to the repository shrunk done at c53e4ae (intially started from old unshrunked repo) Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement reconnect attempts If database can be connected at bridge initialization schedule retry attempts. Prevent query execution scheduling if bridge isn't online Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Minor documentation changes and fix trigger channel name Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix NPE bug initializing ThingActions Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement query actions and another fixes Implement actions to execute query and get last query result Correctly serialize as JSON non scalar results to result channels Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parameters and correct channel Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting and forgot part on previous commit Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Improve documentation Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add javadoc comment and license to all classes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code cleanup Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Untrack unused i18n file Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix log level for query actions trace information Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add dbquery addon to bundles pom Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Temporary remove mqtt bindings that make travis build to fail Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Revert "Temporary remove mqtt bindings that make travis build to fail" This reverts commit 21c0995. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code clean up from static analysis Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update code to be compatible with 3.1.0 Update dependencies version Update Copyright Other minor changes for new static analysis validations. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Requested PR changes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/JDBCBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/DatabaseBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Apply suggestions from code review Co-authored-by: Matthew Skinner <matt@pcmus.com> * Suggestions from code review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parent version Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/jdbc-bridge.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Changes asked in PR review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * README documentation imporovements Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix format issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>

* Initial commit Intial work history lost due to the repository shrunk done at c53e4ae (intially started from old unshrunked repo) Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement reconnect attempts If database can be connected at bridge initialization schedule retry attempts. Prevent query execution scheduling if bridge isn't online Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Minor documentation changes and fix trigger channel name Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix NPE bug initializing ThingActions Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement query actions and another fixes Implement actions to execute query and get last query result Correctly serialize as JSON non scalar results to result channels Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parameters and correct channel Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting and forgot part on previous commit Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Improve documentation Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add javadoc comment and license to all classes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code cleanup Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Untrack unused i18n file Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix log level for query actions trace information Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add dbquery addon to bundles pom Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Temporary remove mqtt bindings that make travis build to fail Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Revert "Temporary remove mqtt bindings that make travis build to fail" This reverts commit 21c0995. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code clean up from static analysis Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update code to be compatible with 3.1.0 Update dependencies version Update Copyright Other minor changes for new static analysis validations. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Requested PR changes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/JDBCBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/DatabaseBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Apply suggestions from code review Co-authored-by: Matthew Skinner <matt@pcmus.com> * Suggestions from code review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parent version Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/jdbc-bridge.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Changes asked in PR review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * README documentation imporovements Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix format issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>

* Initial commit Intial work history lost due to the repository shrunk done at c53e4ae (intially started from old unshrunked repo) Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement reconnect attempts If database can be connected at bridge initialization schedule retry attempts. Prevent query execution scheduling if bridge isn't online Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Minor documentation changes and fix trigger channel name Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix NPE bug initializing ThingActions Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Implement query actions and another fixes Implement actions to execute query and get last query result Correctly serialize as JSON non scalar results to result channels Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parameters and correct channel Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting and forgot part on previous commit Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Improve documentation Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add javadoc comment and license to all classes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code cleanup Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Untrack unused i18n file Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix log level for query actions trace information Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Add dbquery addon to bundles pom Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Temporary remove mqtt bindings that make travis build to fail Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix formatting issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Revert "Temporary remove mqtt bindings that make travis build to fail" This reverts commit 21c0995. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Code clean up from static analysis Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update code to be compatible with 3.1.0 Update dependencies version Update Copyright Other minor changes for new static analysis validations. Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Requested PR changes Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/JDBCBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/java/org/openhab/binding/dbquery/internal/DatabaseBridgeHandler.java Co-authored-by: Matthew Skinner <matt@pcmus.com> * Apply suggestions from code review Co-authored-by: Matthew Skinner <matt@pcmus.com> * Suggestions from code review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update parent version Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/jdbc-bridge.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Update bundles/org.openhab.binding.dbquery/src/main/resources/OH-INF/thing/thing-types.xml Co-authored-by: Matthew Skinner <matt@pcmus.com> * Changes asked in PR review Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Update bundles/org.openhab.binding.dbquery/README.md Co-authored-by: Matthew Skinner <matt@pcmus.com> * README documentation imporovements Signed-off-by: Joan Pujol <joanpujol@gmail.com> * Fix format issue Signed-off-by: Joan Pujol <joanpujol@gmail.com> Co-authored-by: Matthew Skinner <matt@pcmus.com>

lujop requested a review from a team as a code owner October 17, 2020 17:15

cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label Oct 17, 2020

lujop added 15 commits October 17, 2020 23:32

Initial commit

32ce395

Intial work history lost due to the repository shrunk done at c53e4ae (intially started from old unshrunked repo) Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Implement reconnect attempts

93acd40

If database can be connected at bridge initialization schedule retry attempts. Prevent query execution scheduling if bridge isn't online Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Minor documentation changes and fix trigger channel name

c60896e

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Fix NPE bug initializing ThingActions

7974e3a

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Implement query actions and another fixes

ac330ae

Implement actions to execute query and get last query result Correctly serialize as JSON non scalar results to result channels Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Update parameters and correct channel

a275713

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Fix formatting and forgot part on previous commit

98a55ad

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Improve documentation

5874268

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Add javadoc comment and license to all classes

4e75253

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Code cleanup

99f4dbf

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Untrack unused i18n file

e7ee6b2

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Fix log level for query actions trace information

f219a4a

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Add dbquery addon to bundles pom

41e7827

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Temporary remove mqtt bindings that make travis build to fail

21c0995

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Fix formatting issue

b4ac7b5

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

lujop force-pushed the dbquery_initial_submission branch from dbd3d25 to b4ac7b5 Compare October 17, 2020 21:38

Revert "Temporary remove mqtt bindings that make travis build to fail"

06802a8

This reverts commit 21c0995. Signed-off-by: Joan Pujol <joanpujol@gmail.com>

lujop force-pushed the dbquery_initial_submission branch from a46a257 to 06802a8 Compare October 18, 2020 07:22

Code clean up from static analysis

2a6fec8

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

lujop closed this Oct 24, 2020

lujop deleted the dbquery_initial_submission branch October 24, 2020 13:33

lujop restored the dbquery_initial_submission branch October 24, 2020 13:33

lujop reopened this Oct 24, 2020

Skinah added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Feb 25, 2021

Merge branch 'main' into dbquery_initial_submission

ba2ae9f

Changes asked in PR review

b175337

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

lujop requested a review from fwolter September 24, 2021 19:59

lujop added a commit to lujop/openhab-docs that referenced this pull request Sep 24, 2021

Document script context type

a918fb5

Done as suggested by @fwolter in openhab/openhab-addons#8780

Skinah added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 30, 2021

lujop and others added 2 commits September 30, 2021 22:27

Update bundles/org.openhab.binding.dbquery/README.md

0895e03

Co-authored-by: Matthew Skinner <matt@pcmus.com>

README documentation imporovements

cf1155a

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Fix format issue

fc2be94

Signed-off-by: Joan Pujol <joanpujol@gmail.com>

Skinah reviewed Oct 2, 2021

View reviewed changes

bundles/org.openhab.binding.dbquery/pom.xml Show resolved Hide resolved

lujop requested a review from Skinah October 2, 2021 05:00

Skinah approved these changes Oct 15, 2021

View reviewed changes

fwolter approved these changes Oct 17, 2021

View reviewed changes

fwolter merged commit 6cb5652 into openhab:main Oct 17, 2021

fwolter added this to the 3.2 milestone Oct 17, 2021

lujop mentioned this pull request Oct 19, 2021

[dbquery] Create NOTICE file #11415

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dbquery] Initial contribution #8780

[dbquery] Initial contribution #8780

lujop commented Oct 17, 2020 •

edited

Loading

TravisBuddy commented Oct 17, 2020 •

edited

Loading

Skinah commented Feb 25, 2021

lujop commented Sep 24, 2021

Skinah commented Sep 30, 2021

lujop commented Sep 30, 2021

Skinah commented Oct 1, 2021

lujop commented Oct 1, 2021 •

edited

Loading

Skinah commented Oct 2, 2021

Skinah left a comment

fwolter left a comment

fwolter commented Oct 17, 2021

lujop commented Oct 17, 2021

[dbquery] Initial contribution #8780

[dbquery] Initial contribution #8780

Conversation

lujop commented Oct 17, 2020 • edited Loading

DBQuery Initial contribution

TravisBuddy commented Oct 17, 2020 • edited Loading

TravisBuddy Request Identifier: 4c891b70-160a-11eb-94fa-edf6748ec8ed

Skinah commented Feb 25, 2021

lujop commented Sep 24, 2021

Skinah commented Sep 30, 2021

lujop commented Sep 30, 2021

Skinah commented Oct 1, 2021

lujop commented Oct 1, 2021 • edited Loading

Skinah commented Oct 2, 2021

Skinah left a comment

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

fwolter commented Oct 17, 2021

lujop commented Oct 17, 2021

lujop commented Oct 17, 2020 •

edited

Loading

TravisBuddy commented Oct 17, 2020 •

edited

Loading

lujop commented Oct 1, 2021 •

edited

Loading