[withings] Initial contribution (#4395) #9154

Novanic · 2020-11-27T21:42:38Z

This pull-request (re-)adds support for Withings devices and data. There was already a binding with OpenHAB 1 which isn't working with OpenHAB 2 anymore. This binding is now a new rewritten binding for OpenHAB 3 which uses newer features like things and discovery.

This first version supports scales and sleep monitors.

See issue #4395 for more information.

Update

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

Update

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

chris400 · 2020-11-28T10:47:51Z

(pls don't blame me, I am not a developer)
Might it be possible to fire a trigger, when the person starts to sleep? I did some digging in the Withings API, but did not find it.

Novanic · 2020-11-29T12:33:31Z

(pls don't blame me, I am not a developer)
Might it be possible to fire a trigger, when the person starts to sleep? I did some digging in the Withings API, but did not find it.

Unfortunately not (yet). That would require that the OpenHAB installation is public accessible via the internet. Without that, the Withings API does provide the sleep start information unfortunately only after the sleep session is ended (when the user stands up after sleeping).

fwolter

Thanks for your contribution! I reviewed your code and here is my feedback.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

bundles/org.openhab.binding.withings/NOTICE

fwolter · 2020-11-30T10:46:05Z

bundles/org.openhab.binding.withings/README.md

+
+### 2. Bridge Configuration
+
+- Create a new Withings API Thing with Paper UI


Can you express this more abstract, as PaperUI will be removed in OH3?

ok, and what is the name of the new configuration UI?

Main UI. But it's better to express it abstractly, that no mention of a specific UI is necessary.

Ok, I changed that to Main UI. As I know there is currently no other configuration/setup UI and I wouldn't recommend to configure the things with the configuration files, because it would be complicated and the users would have to remove the auth-code manually at the right time, that may cause problems. That problem causes still many support questions at the Innogy binding.

fwolter · 2020-11-30T10:58:30Z

...ing.withings/src/main/java/org/openhab/binding/withings/internal/WithingsHandlerFactory.java

+public class WithingsHandlerFactory extends BaseThingHandlerFactory {
+
+    private final Logger logger = LoggerFactory.getLogger(WithingsHandlerFactory.class);
+    private final Map<ThingUID, @Nullable ServiceRegistration<?>> discoveryServiceRegs = new HashMap<>();


You could use the ThingHandlerService to make discovery registration code simpler. See the yet unmerged documentation: https://github.com/openhab/openhab-docs/pull/1262/files#diff-c4a4d8725430bc2ea046182bfc73ac51349d989c7f6a8a6fa3001a226a09ad98R932

Hm, there is no binding / example which already uses that and the documentation doesn't help me to imagine how can help that to simplify it. :-(

There are several addons using it. E.g. the LCN binding.

...ing.withings/src/main/java/org/openhab/binding/withings/internal/WithingsHandlerFactory.java

...ing.withings/src/main/java/org/openhab/binding/withings/internal/api/AbstractAPIHandler.java

bundles/org.openhab.binding.withings/src/main/resources/OH-INF/thing/person.xml

bundles/org.openhab.binding.withings/src/main/resources/OH-INF/thing/scale.xml

bundles/org.openhab.binding.withings/src/main/resources/OH-INF/thing/sleepmonitor.xml

bundles/pom.xml

Update

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

radokristof · 2020-12-13T13:25:48Z

bundles/org.openhab.binding.withings/README.md

+
+### 1. Application Creation
+
+Register a new Withings application here: https://account.withings.com/partner/add_oauth2


How can I create an application there? What is the Callback URL? Everyone needs to register openHAB as an application at this site?

Novanic · 2020-12-20T11:58:42Z

I'm sorry but I recall the pull-request for the moment, because...

... there seems to be less interest in that binding
... there is no comment from the author of issue Add Withings Binding #4395 / if it is sufficient to fulfill the requirements
... the setup process is a little bit annoying and can not get improved yet (has to work without a public accessible OpenHAB installation and the authorize link can not get generated dynamically). At least this pain appears only one time, so it could be ok for a first version. Maybe that can get improved in the future within OpenHAB and with OpenHAB-Cloud.
... but the main reason is that I get no sufficient answer from Withings if the approach is ok to let the users registrating there own application (with client id and client secret) at Withings. There are other applications which use the same approach (for example the OpenHAB v1 binding and "Home Assistant") but probably the official way is that 1 application uses 1 client id. That wouldn't work in this case because the secret can not get saved secure in an open-source project and also the quotas wouldn't be sufficient. Therefore I want to get a confirmation from Withings that the approach is ok to don't cause any risk.

chris400 · 2020-12-20T18:21:49Z

I am interested in the binding! :)
But I do not have much to provide within its development, so I did not comment on it.

Novanic and others added 8 commits October 3, 2020 23:14

Merge pull request #1 from openhab/main

7515b82

Update

Merge pull request #3 from openhab/main

888a1cc

Update

Withings binding introduced

a61944c

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Migration to OH 3

c87c9f5

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Warnings fixed

28ae969

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] README updated

e1695a7

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

Merge pull request #4 from openhab/main

3161453

Update

Merge remote-tracking branch 'remotes/origin/main' into withings-3

f4da18c

Novanic mentioned this pull request Nov 27, 2020

Add Withings Binding #4395

Closed

Novanic marked this pull request as draft November 27, 2020 21:57

[withings] New NonNull violations fixed

d839aa7

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

Novanic marked this pull request as ready for review November 28, 2020 06:32

[withings] One more pom.xml extended for the withings binding

cd86faf

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

fwolter added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Nov 28, 2020

fwolter requested changes Nov 30, 2020

View reviewed changes

Hilbrand mentioned this pull request Dec 1, 2020

openHAB 1 addon compatibility overview with openHAB 3 #6179

Closed

Novanic and others added 2 commits December 4, 2020 21:15

Merge pull request #5 from openhab/main

b38992e

Update

Merge remote-tracking branch 'remotes/origin/main' into withings-3

d62ced5

Novanic requested a review from a team as a code owner December 4, 2020 20:17

sstrohschein added 6 commits December 4, 2020 22:39

[withings] Optimizations (from review)

8a05cd1

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Optimizations (from review)

09dd91b

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Optimizations (from review)

edf2217

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Optimizations (from review)

04302b3

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Optimizations (from review)

9c61e18

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

[withings] Optimizations (from review)

ee74708

Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>

radokristof reviewed Dec 13, 2020

View reviewed changes

Novanic marked this pull request as draft December 13, 2020 19:35

wborn added the bounty Issues with a Bountysource reward and the PRs that solve these label Dec 15, 2020

wborn linked an issue Dec 15, 2020 that may be closed by this pull request

Add Withings Binding #4395

Closed

Novanic closed this Dec 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[withings] Initial contribution (#4395) #9154

[withings] Initial contribution (#4395) #9154

Novanic commented Nov 27, 2020 •

edited

Loading

chris400 commented Nov 28, 2020

Novanic commented Nov 29, 2020 •

edited

Loading

fwolter left a comment

fwolter Nov 30, 2020

Novanic Dec 4, 2020

fwolter Dec 4, 2020

Novanic Dec 5, 2020

fwolter Nov 30, 2020

Novanic Dec 5, 2020 •

edited

Loading

fwolter Dec 6, 2020

radokristof Dec 13, 2020

Novanic commented Dec 20, 2020 •

edited

Loading

chris400 commented Dec 20, 2020


		### 2. Bridge Configuration

		- Create a new Withings API Thing with Paper UI


		### 1. Application Creation

		Register a new Withings application here: https://account.withings.com/partner/add_oauth2

[withings] Initial contribution (#4395) #9154

[withings] Initial contribution (#4395) #9154

Conversation

Novanic commented Nov 27, 2020 • edited Loading

chris400 commented Nov 28, 2020

Novanic commented Nov 29, 2020 • edited Loading

fwolter left a comment

Choose a reason for hiding this comment

fwolter Nov 30, 2020

Choose a reason for hiding this comment

Novanic Dec 4, 2020

Choose a reason for hiding this comment

fwolter Dec 4, 2020

Choose a reason for hiding this comment

Novanic Dec 5, 2020

Choose a reason for hiding this comment

fwolter Nov 30, 2020

Choose a reason for hiding this comment

Novanic Dec 5, 2020 • edited Loading

Choose a reason for hiding this comment

fwolter Dec 6, 2020

Choose a reason for hiding this comment

radokristof Dec 13, 2020

Choose a reason for hiding this comment

Novanic commented Dec 20, 2020 • edited Loading

chris400 commented Dec 20, 2020

Novanic commented Nov 27, 2020 •

edited

Loading

Novanic commented Nov 29, 2020 •

edited

Loading

Novanic Dec 5, 2020 •

edited

Loading

Novanic commented Dec 20, 2020 •

edited

Loading