Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus] Moved modbus transport from addons to core #9268

Merged
merged 5 commits into from
Dec 8, 2020
Merged

[modbus] Moved modbus transport from addons to core #9268

merged 5 commits into from
Dec 8, 2020

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented Dec 6, 2020 •
edited
Loading

addresses openhab/openhab-core#1435
depends on openhab/openhab-core#1892

Signed-off-by: Kai Kreuzer kai@openhab.org

@kaikreuzer kaikreuzer marked this pull request as ready for review December 6, 2020 23:05
bern77
bern77 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@bern77 bern77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pail23
pail23 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@pail23 pail23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ssalonen
ssalonen approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@ssalonen ssalonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ssalonen
ssalonen requested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@ssalonen ssalonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that some pom.xml files need touching as well

bundles/org.openhab.binding.modbus/pom.xml Show resolved Hide resolved
@wborn wborn added the awaiting other PR Depends on another PR label Dec 7, 2020
@wborn
Copy link
Member

wborn commented Dec 8, 2020

Looks like all PR builds will fail now due to a StackOverflowError in Karaf feature verification until this PR is probably merged.

I debugged the failing build of #9283 (https://ci.openhab.org/job/PR-openHAB-Addons/1257/console) locally:

[INFO] openHAB Add-ons :: Bundles :: IO :: Modbus Transport FAILURE [01:15 min]


...

[ERROR] StackOverflowError -> [Help 1]
java.lang.StackOverflowError
    at java.util.WeakHashMap.get (WeakHashMap.java:398)
    at org.apache.felix.utils.version.VersionTable.getVersion (VersionTable.java:52)
    at org.apache.felix.utils.version.VersionRange.<init> (VersionRange.java:118)
    at org.apache.felix.utils.version.VersionRange.<init> (VersionRange.java:100)
    at org.apache.felix.utils.version.VersionRange.<init> (VersionRange.java:95)
    at org.apache.karaf.features.internal.resolver.ResourceUtils.addIdentityRequirement (ResourceUtils.java:99)
    at org.apache.karaf.features.internal.region.Subsystem.requireFeature (Subsystem.java:284)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:350)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
...
    at org.apache.karaf.features.internal.region.Subsystem.build (Subsystem.java:332)
    at org.apache.karaf.features.internal.region.Subsystem.doBuild (Subsystem.java:390)
[ERROR] 
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/StackOverflowError

There's probably some cycle now until the transport is removed from this repo.

@kaikreuzer kaikreuzer mentioned this pull request Dec 8, 2020
Merged
@kaikreuzer kaikreuzer removed the awaiting other PR Depends on another PR label Dec 8, 2020
@kaikreuzer
Moved modbus transport from addons to core
80f4c9d 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
fixed all poms
9aa2425 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
some more fixes after rebase
005fadc 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
adapted itests
bb2868b 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 8, 2020
@cpmeister
Copy link
Contributor

The build is still failing karaf verification.

@kaikreuzer
removed unnecessary feature definitions
3355af6 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member Author

I'm aware of it, still working on it...

@kaikreuzer
Copy link
Member Author

Build succeeded - only one unrelated mqtt test failed...

wborn
wborn approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's merge it so the other builds can succeed again. :-)

@wborn wborn merged commit f152a58 into openhab:main Dec 8, 2020
@wborn wborn added this to the 3.0.0.RC1 milestone Dec 13, 2020
ssalonen added a commit to ssalonen/openhab2-addons that referenced this pull request Jan 19, 2021
@ssalonen
[modbus] update verbose logging guide in README
84742a9 
As a result of openhab#9268 the logger is now in core.

Signed-off-by: Sami Salonen <ssalonen @gmail.com>
This was referenced Jan 19, 2021
Closed
Closed
ssalonen added a commit to ssalonen/openhab2-addons that referenced this pull request Jan 19, 2021
@ssalonen
[modbus] update verbose logging guide in README
49b5d3e 
As a result of openhab#9268 the logger is now in core.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen mentioned this pull request Jan 19, 2021
Merged
wborn pushed a commit that referenced this pull request Jan 19, 2021
@ssalonen
[modbus] update verbose logging guide in README (#9871)
c81e0c0 
As a result of #9268 the logger is now in core.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@kaikreuzer
[modbus] Moved modbus transport from addons to core (openhab#9268)
9cd7fcc
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@ssalonen
[modbus] update verbose logging guide in README (openhab#9871)
67839a9 
As a result of openhab#9268 the logger is now in core.
@Hilbrand
Copy link
Member

Question: The feature files are removed from the modbus bundles in this pr. Should that be done for the other similar bindings as well? Like mqtt and bluetooth?

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@ssalonen @themillhousegroup
[modbus] update verbose logging guide in README (openhab#9871)
621b54e 
As a result of openhab#9268 the logger is now in core.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@ssalonen @thinkingstone
[modbus] update verbose logging guide in README (openhab#9871)
bc5fdec 
As a result of openhab#9268 the logger is now in core.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@kaikreuzer kaikreuzer deleted the mbm branch November 13, 2021 18:57
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@kaikreuzer
[modbus] Moved modbus transport from addons to core (openhab#9268)
d4a4352 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@ssalonen
[modbus] update verbose logging guide in README (openhab#9871)
4c8ff19 
As a result of openhab#9268 the logger is now in core.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@pail23 pail23 pail23 approved these changes

@bern77 bern77 bern77 approved these changes

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0.RC1
Development

Successfully merging this pull request may close these issues.
7 participants
@kaikreuzer @wborn @cpmeister @Hilbrand @ssalonen @pail23 @bern77