-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[epsonprojector] Add ESC/VP.net handshake for projectors with built-in ethernet #9375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cpmeister
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Dec 15, 2020
fwolter
requested changes
Dec 15, 2020
...rc/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorBindingConstants.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/binding/epsonprojector/internal/connector/EpsonProjectorTcpConnector.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/epsonprojector/internal/discovery/EpsonProjectorDiscoveryService.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/epsonprojector/internal/discovery/EpsonProjectorDiscoveryService.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/epsonprojector/internal/discovery/EpsonProjectorDiscoveryService.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/epsonprojector/internal/discovery/EpsonProjectorDiscoveryService.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/epsonprojector/internal/discovery/EpsonProjectorDiscoveryService.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/epsonprojector/internal/discovery/EpsonProjectorDiscoveryService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/openhab/binding/epsonprojector/internal/discovery/MulticastListener.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/openhab/binding/epsonprojector/internal/discovery/MulticastListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
fwolter
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cpmeister
approved these changes
Dec 24, 2020
cpmeister
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Dec 24, 2020
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
…n ethernet (openhab#9375) Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
…n ethernet (openhab#9375) Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/is-the-epson-projector-binding-abandoned/107769/56 |
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…n ethernet (openhab#9375) Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…n ethernet (openhab#9375) Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some newer projectors have a built-in Ethernet port that listens for a connection on port 3629. This change sends a special string to initialize the connection. After the initialization string is sent, the normal serial commands can be used. Without the string being sent, the projector would terminate the connection. A discovery service was also added to automatically locate the projector on the network and add the discovered thing to the inbox.
Previously raised in this issue: openhab/openhab1-addons#5604
Test build:
https://github.com/mlobstein/mlobstein-beta-test/raw/master/org.openhab.binding.epsonprojector-3.0.0-SNAPSHOT.jar
https://github.com/mlobstein/mlobstein-beta-test/raw/master/org.openhab.binding.epsonprojector-3.0.0-SNAPSHOT-sources.jar