Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc] Consider local timezone to create time filter #9445

Merged
merged 4 commits into from
Dec 24, 2020

Conversation

cweitkamp
Copy link
Contributor

@cweitkamp cweitkamp commented Dec 20, 2020

  • Consider local timezone to create time filter

Fixes #8502
Fixes #9308
Fixes #9446

This is the easy way. Alternatively we can use the LocaleProvider to use the user defined timezone.

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label Dec 20, 2020
@cweitkamp cweitkamp requested a review from a team as a code owner December 20, 2020 19:35
@cpmeister
Copy link
Contributor

I'd prefer if we used the user defined timezone instead.

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 23, 2020
@cpmeister cpmeister merged commit 133df3a into openhab:main Dec 24, 2020
@cpmeister cpmeister added this to the 3.1 milestone Dec 24, 2020
@cweitkamp cweitkamp deleted the bugfix-jdbc-time-filter branch December 24, 2020 07:34
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
* Consider local timezone to create time filter
* Use user-defined timeZone

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
* Consider local timezone to create time filter
* Use user-defined timeZone

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Jan 10, 2021
cweitkamp added a commit that referenced this pull request Jan 10, 2021
* Consider local timezone to create time filter
* Use user-defined timeZone

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* Consider local timezone to create time filter
* Use user-defined timeZone

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Consider local timezone to create time filter
* Use user-defined timeZone

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
2 participants