-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jdbc] Consider local timezone to create time filter #9445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
bug
An unexpected problem or unintended behavior of an add-on
label
Dec 20, 2020
I'd prefer if we used the user defined timezone instead. |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cpmeister
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cpmeister
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Dec 23, 2020
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Consider local timezone to create time filter * Use user-defined timeZone Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Consider local timezone to create time filter * Use user-defined timeZone Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
cweitkamp
added
the
patch
A PR that has been cherry-picked to a patch release branch
label
Jan 10, 2021
cweitkamp
added a commit
that referenced
this pull request
Jan 10, 2021
* Consider local timezone to create time filter * Use user-defined timeZone Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* Consider local timezone to create time filter * Use user-defined timeZone Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Consider local timezone to create time filter * Use user-defined timeZone Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8502
Fixes #9308
Fixes #9446
This is the easy way. Alternatively we can use the
LocaleProvider
to use the user defined timezone.Signed-off-by: Christoph Weitkamp github@christophweitkamp.de