[hue] Catch exception if 'AllGroup' does not exist #9502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
bug
cweitkamp
changed the title
lolodomo
reviewed
Dec 25, 2020
| @@ -425,8 +426,6 @@ public String setLightName(HueObject light, String name) throws IOException, Api | |||
| * @return all lights pseudo group | |||
| */ | |||
| public Group getAllGroup() { | |||
| requireAuthentication(); | |||
There was a problem hiding this comment.
Was it there really for no valid reason ?
This is requiring a good analysis.
There was a problem hiding this comment.
The deep analysis will reveal that this method (getAllGroup()) never has been used before.
J-N-K
approved these changes
Dec 25, 2020
|
Code looks good. Woudl you want to wait for the additional testing? |
cweitkamp
added a commit
that referenced
this pull request
Dec 27, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
removed
the
additional testing preferred
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
cweitkamp
added
the
patch
cweitkamp
added a commit
that referenced
this pull request
Jan 10, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9175
// CC @olemr
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de